Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the amount of business code in DiagramRenderer #2235

Closed
1 of 2 tasks
gcoutable opened this issue Aug 8, 2023 · 1 comment · Fixed by #2422
Closed
1 of 2 tasks

Reduce the amount of business code in DiagramRenderer #2235

gcoutable opened this issue Aug 8, 2023 · 1 comment · Fixed by #2422
Assignees
@sbegaudeau
Labels
difficulty: medium package: diagrams type: enhancement
Milestone
2023.12.0

Comments

@gcoutable
Copy link
Contributor

Prevent the DiagramRenderer used to render the diagram with react flow to finish like the DiagramRepresentation used to render the diagram with Sprotty, with a lot of business code hard to maintain.
@gcoutable gcoutable self-assigned this Aug 8, 2023
@gcoutable gcoutable added this to the 2023.10.0 milestone Aug 9, 2023
sbegaudeau added a commit that referenced this issue Sep 26, 2023
@sbegaudeau
[2235] Reduce the amount of code in DiagramRenderer
d015f3e 
Bug: #2235
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau mentioned this issue Sep 26, 2023
Merged
39 tasks
@sbegaudeau sbegaudeau linked a pull request Oct 2, 2023 that will close this issue
[2235] Reduce the amount of code in DiagramRenderer #2422
Merged
39 tasks
@sbegaudeau
Copy link
Member

Reopening this since the PR has not been merged

@sbegaudeau sbegaudeau reopened this Oct 4, 2023
@sbegaudeau sbegaudeau modified the milestones: 2023.10.0, 2023.12.0 Oct 4, 2023
@sbegaudeau sbegaudeau assigned sbegaudeau and unassigned gcoutable Oct 4, 2023
sbegaudeau added a commit that referenced this issue Nov 15, 2023
@sbegaudeau
[2235] Reduce the amount of code in DiagramRenderer
aa95d80 
Bug: #2235
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
AxelRICHARD pushed a commit that referenced this issue Nov 15, 2023
@sbegaudeau @AxelRICHARD
[2235] Reduce the amount of code in DiagramRenderer
34d2c97 
Bug: #2235
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbegaudeau sbegaudeau

Labels
difficulty: medium package: diagrams type: enhancement
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging a pull request may close this issue.

[2235] Reduce the amount of code in DiagramRenderer eclipse-sirius/sirius-web
2 participants
@sbegaudeau @gcoutable