Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use layout strategy to layout list items #2289

Closed
gcoutable opened this issue Aug 21, 2023 · 0 comments · Fixed by #2315
Closed

Use layout strategy to layout list items #2289

gcoutable opened this issue Aug 21, 2023 · 0 comments · Fixed by #2315
Assignees
@gcoutable
Labels
difficulty: medium package: diagrams type: enhancement
Milestone
2023.12.0

Comments

@gcoutable
Copy link
Contributor

Is this free form compartment
@gcoutable gcoutable self-assigned this Aug 21, 2023
@gcoutable gcoutable added this to the 2023.10.0 milestone Aug 21, 2023
@gcoutable gcoutable changed the title Support nodes with a free form layout Use layout strategy to layout list items Aug 22, 2023
gcoutable added a commit that referenced this issue Sep 4, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
0657ae6 
TODO:
- The node list label can go outside of its container
- There is to much space between the node list label and its children

Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable linked a pull request Sep 4, 2023 that will close this issue
[2289] Use layout strategy to layout icon label nodes #2315
Merged
39 tasks
gcoutable added a commit that referenced this issue Sep 11, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
525e1f0 
TODO:
- Prevent the node list label to go outside of its container
- Reduce the space between the node list label and its children
- Prevent icon labels to be wrapped into two lines

Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 14, 2023
@gcoutable
[2289] Take the border width in children positioning
195a715 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 14, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
8a48997 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 15, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
907bb7b 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 18, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
bb9b145 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 18, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
aef306f 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 20, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
c4eb4a3 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 20, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
5b0856c 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 20, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
79cd540 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Sep 26, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
9b305f5 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@sbegaudeau sbegaudeau modified the milestones: 2023.10.0, 2023.12.0 Oct 2, 2023
gcoutable added a commit that referenced this issue Oct 9, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
f92bda7 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 10, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
35f8743 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 10, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
7be1ff3 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 10, 2023
@gcoutable
[2289] Use layout strategy to layout icon label nodes
e28f831 
Bug: #2289
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcoutable gcoutable

Labels
difficulty: medium package: diagrams type: enhancement
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging a pull request may close this issue.

[2289] Use layout strategy to layout icon label nodes eclipse-sirius/sirius-web
2 participants
@sbegaudeau @gcoutable