Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for label location (TOP_CENTER only) #2482

Closed
Tracked by #2290
gcoutable opened this issue Oct 18, 2023 · 1 comment · Fixed by #2507
Closed
Tracked by #2290

Add the support for label location (TOP_CENTER only) #2482

gcoutable opened this issue Oct 18, 2023 · 1 comment · Fixed by #2507

Comments

@gcoutable
Copy link
Contributor

gcoutable commented Oct 18, 2023

Location

The inside label can be located on:

  • TOP_LEFT
  • TOP_CENTER
  • TOP_RIGHT
  • LEFT_CENTER
  • CENTER
  • RIGHT_CENTER
  • BOTTOM_LEFT
  • BOTTOM_CENTER
  • BOTTOM_RIGHT

The label needs to contain its location. We need to add the following concepts:

public enum InsideLabelLocation {
  TOP_LEFT,
  TOP_CENTER,
  TOP_RIGHT,
  LEFT_CENTER,
  CENTER,
  RIGHT_CENTER,
  BOTTOM_LEFT,
  BOTTOM_CENTER,
  BOTTOM_RIGHT,
}
public class InsideLabel {
  private InsideLabelLocation location;
}

At this point in time, we will not be able to have outside labels anymore. In the odesign compatibility layer, the inside label will be configured to TOP_CENTER while it will be configurable in the View DSL.

This should be tested with list nodes

@gcoutable gcoutable added this to the 2023.12.0 milestone Oct 18, 2023
@gcoutable gcoutable changed the title Add the support for label location Add the support for label location (TOP_CENTER only) Oct 18, 2023
@gcoutable
Copy link
Contributor Author

For the first implementation, we will support only TOP_CENTER labels

@gcoutable gcoutable self-assigned this Oct 23, 2023
gcoutable added a commit that referenced this issue Oct 25, 2023
Bug: #2482
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 25, 2023
Bug: #2482
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 25, 2023
Bug: #2482
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@pcdavid pcdavid linked a pull request Oct 25, 2023 that will close this issue
39 tasks
gcoutable added a commit that referenced this issue Oct 27, 2023
Bug: #2482
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
pcdavid pushed a commit that referenced this issue Oct 27, 2023
Bug: #2482
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant