Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support for header in nodes (TOP_CENTER only) #2483

Closed
Tracked by #2290
gcoutable opened this issue Oct 18, 2023 · 0 comments · Fixed by #2517
Closed
Tracked by #2290

Add the support for header in nodes (TOP_CENTER only) #2483

gcoutable opened this issue Oct 18, 2023 · 0 comments · Fixed by #2517

Comments

@gcoutable
Copy link
Contributor

gcoutable commented Oct 18, 2023

A header can prevent child nodes from overlapping the label area. The header can be located at the top for TOP_XXX labels, the bottom for BOTTOM_XXX labels, on the left for LEFT_CENTER, and on the right for RIGHT_CENTER labels.

A CENTER label cannot have the property header -> This should not be possible in the creation of the InsideLabel#build() and we should thus throw an IllegalArgumentException here to prevent this use case from ever reaching the frontend. Add the class to a whitelist for the GeneralPurposeTests class. In the view DSL, always remove the header option, when converting, even if the option is true when the label's location is CENTER.

The label must be a header in a node with a list layout strategy. Throw an exception if that's not the case. In the view DSL, always set the header option to true if the parent node has a list layout strategy even if the option is set to false.

org.eclipse.sirius.components.diagrams.RectangularNodeStyle#withHeader should move to InsideLabelDescription.

@gcoutable gcoutable added this to the 2023.12.0 milestone Oct 18, 2023
@gcoutable gcoutable self-assigned this Oct 26, 2023
gcoutable added a commit that referenced this issue Oct 26, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 26, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 26, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable linked a pull request Oct 26, 2023 that will close this issue
39 tasks
gcoutable added a commit that referenced this issue Oct 30, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 30, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 30, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 30, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable linked a pull request Oct 30, 2023 that will close this issue
39 tasks
gcoutable added a commit that referenced this issue Oct 31, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 31, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 31, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
pcdavid pushed a commit that referenced this issue Oct 31, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
pcdavid pushed a commit that referenced this issue Oct 31, 2023
Bug: #2483
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment