Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create child nodes where the user has clicked #2504

Closed
mcharfadi opened this issue Oct 24, 2023 · 0 comments · Fixed by #2505
Closed

Create child nodes where the user has clicked #2504

mcharfadi opened this issue Oct 24, 2023 · 0 comments · Fixed by #2505
Assignees
@mcharfadi
Labels
difficulty: medium package: diagrams type: enhancement
Milestone
2023.12.0

Comments

@mcharfadi
Copy link
Contributor

mcharfadi commented Oct 24, 2023 •
edited

With ReactFlow renderer, the nodes are currently positioned by the layout algorithm.
The node should be positioned at the cursor position.

It should also work for drop actions.

We should make sure the newly created element does not overlap existing ones.
@mcharfadi mcharfadi added this to the 2023.12.0 milestone Oct 24, 2023
@mcharfadi mcharfadi self-assigned this Oct 24, 2023
mcharfadi added a commit that referenced this issue Oct 24, 2023
@mcharfadi
[2504] Use tool position to place created node
70385aa 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
@mcharfadi mcharfadi mentioned this issue Oct 24, 2023
Merged
39 tasks
@mcharfadi mcharfadi linked a pull request Oct 24, 2023 that will close this issue
[2504] Use tool position to place created node #2505
Merged
39 tasks
@mcharfadi mcharfadi changed the title Create nodes at the position of the cursor Create child nodes where the user has clicked Oct 26, 2023
mcharfadi added a commit that referenced this issue Oct 26, 2023
@mcharfadi
[2504] Use tool position to place created node
98aa295 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
mcharfadi added a commit that referenced this issue Oct 26, 2023
@mcharfadi
[2504] Use tool position to place created node
0ca931f 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Oct 27, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
67a7194 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 2, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
269bd33 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
71bb42b 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
1c2daca 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
fab655b 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
746dca9 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
6fc2056 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
4c8e182 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
fdbfac6 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
gcoutable pushed a commit that referenced this issue Nov 3, 2023
@mcharfadi @gcoutable
[2504] Use tool position to place created node
00da57b 
Bug: #2504
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcharfadi mcharfadi

Labels
difficulty: medium package: diagrams type: enhancement
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging a pull request may close this issue.

[2504] Use tool position to place created node eclipse-sirius/sirius-web
1 participant
@mcharfadi