Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React flow node compartments are smaller than their parents #2513

Closed
4 tasks done
AxelRICHARD opened this issue Oct 27, 2023 · 0 comments · Fixed by #2519
Closed
4 tasks done

React flow node compartments are smaller than their parents #2513

AxelRICHARD opened this issue Oct 27, 2023 · 0 comments · Fixed by #2519
Assignees
@gcoutable
Labels
difficulty: medium package: diagrams type: bug
Milestone
2023.12.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • 2023.10.4
  • I have specified my environment :
  • All

Screenshots

With react-flow:
Capture d’écran 2023-10-27 à 15 04 06

With former rendering library:
Capture d’écran 2023-10-27 à 15 05 51

Expected behavior

compartments have same width than their parents

Actual behavior

compartments are smaller than their parents
@AxelRICHARD AxelRICHARD added this to the 2023.12.0 milestone Oct 27, 2023
@gcoutable gcoutable self-assigned this Oct 30, 2023
gcoutable added a commit that referenced this issue Oct 31, 2023
@gcoutable
[2513] Hide node borders in a list layout
95ac1d6 
The other solution could have to make node borders overlap by reducing
the size of the node.
But a list laid out node can have compartment or icon label (other kind
of node could be supported later) without knowing it.
With that solution the size of the parent should have been reduced if it
has included compartment, but not with icon label.
We do not want the layout of a node to know the type of its children,
that why we have chosen to hide border instead.

Bug: #2513
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 31, 2023
@gcoutable
[2513] Hide node borders in a list layout
0e92eee 
The other solution could have to make node borders overlap by reducing
the size of the node.
But a list laid out node can have compartment or icon label (other kind
of node could be supported later) without knowing it.
With that solution the size of the parent should have been reduced if it
has included compartment, but not with icon label.
We do not want the layout of a node to know the type of its children,
that why we have chosen to hide border instead.

Bug: #2513
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable linked a pull request Oct 31, 2023 that will close this issue
[2513] Hide node borders in a list layout #2519
Merged
39 tasks
gcoutable added a commit that referenced this issue Oct 31, 2023
@gcoutable
[2513] Hide node borders in a list layout
2934db4 
The other solution could have to make node borders overlap by reducing
the size of the node.
But a list laid out node can have compartment or icon label (other kind
of node could be supported later) without knowing it.
With that solution the size of the parent should have been reduced if it
has included compartment, but not with icon label.
We do not want the layout of a node to know the type of its children,
that why we have chosen to hide border instead.

Bug: #2513
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 31, 2023
@gcoutable
[2513] Hide node borders in a list layout
3ce28df 
The other solution could have to make node borders overlap by reducing
the size of the node.
But a list laid out node can have compartment or icon label (other kind
of node could be supported later) without knowing it.
With that solution the size of the parent should have been reduced if it
has included compartment, but not with icon label.
We do not want the layout of a node to know the type of its children,
that why we have chosen to hide border instead.

Bug: #2513
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Oct 31, 2023
@gcoutable
[2513] Hide node borders in a list layout
621ca69 
The other solution could have to make node borders overlap by reducing
the size of the node.
But a list laid out node can have compartment or icon label (other kind
of node could be supported later) without knowing it.
With that solution the size of the parent should have been reduced if it
has included compartment, but not with icon label.
We do not want the layout of a node to know the type of its children,
that why we have chosen to hide border instead.

Bug: #2513
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
pcdavid pushed a commit that referenced this issue Oct 31, 2023
@gcoutable @pcdavid
[2513] Hide node borders in a list layout
771638c 
The other solution could have to make node borders overlap by reducing
the size of the node.
But a list laid out node can have compartment or icon label (other kind
of node could be supported later) without knowing it.
With that solution the size of the parent should have been reduced if it
has included compartment, but not with icon label.
We do not want the layout of a node to know the type of its children,
that why we have chosen to hide border instead.

Bug: #2513
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcoutable gcoutable

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging a pull request may close this issue.

[2513] Hide node borders in a list layout eclipse-sirius/sirius-web
2 participants
@AxelRICHARD @gcoutable