Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edges stop at the new creation handles instead of the border of their target node #2571

Closed
pcdavid opened this issue Nov 14, 2023 · 0 comments · Fixed by #2578
Closed

Edges stop at the new creation handles instead of the border of their target node #2571

pcdavid opened this issue Nov 14, 2023 · 0 comments · Fixed by #2578
Assignees
@pcdavid
Labels
difficulty: medium package: diagrams type: bug
Milestone
2023.12.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Nov 14, 2023

Since edge creation handles have been introduced, edges are only drawn up to them instead of up to the old "black dots" which where much closer to the actual target node's edge:

Capture.video.du.2023-11-14.14-56-37.webm
@pcdavid pcdavid added this to the 2023.12.0 milestone Nov 14, 2023
@pcdavid pcdavid self-assigned this Nov 14, 2023
pcdavid added a commit that referenced this issue Nov 15, 2023
@pcdavid
[2571] Make sure edges are drawn up to the border of their target node
28c3c5e 
Bug: #2571
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Nov 15, 2023
Merged
39 tasks
@pcdavid pcdavid linked a pull request Nov 15, 2023 that will close this issue
[2571] Make sure edges are drawn up to the border of their target node #2578
Merged
39 tasks
mcharfadi pushed a commit that referenced this issue Nov 15, 2023
@pcdavid @mcharfadi
[2571] Make sure edges are drawn up to the border of their target node
5b53288 
Bug: #2571
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging a pull request may close this issue.

[2571] Make sure edges are drawn up to the border of their target node eclipse-sirius/sirius-web
1 participant
@pcdavid