Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid text cursor position when triggering direct edit on React Flow diagram #2579

Closed
pcdavid opened this issue Nov 15, 2023 · 0 comments · Fixed by #2664
Closed

Invalid text cursor position when triggering direct edit on React Flow diagram #2579

pcdavid opened this issue Nov 15, 2023 · 0 comments · Fixed by #2664
Assignees
@pcdavid
Labels
difficulty: medium package: diagrams type: bug
Milestone
2024.1.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Nov 15, 2023

Steps to reproduce:

  1. Create/open a diagram which uses React Flow and with at least one node with an editable label.
  2. Select the node.
  3. Start typing a new text for the label (e.g. "New Label").

The first character you type is placed at the end of the input, but the cursor is at the beginning of the input (so before the initial character). The resulting text is "ew LabelN" with the "N" at the end instead of the beginning.
@pcdavid pcdavid added this to the 2023.12.0 milestone Nov 15, 2023
@pcdavid pcdavid changed the title Invlid text cursor position when triggering direct edit on React Flow diagram Invalid text cursor position when triggering direct edit on React Flow diagram Nov 15, 2023
@pcdavid pcdavid self-assigned this Nov 28, 2023
@sbegaudeau sbegaudeau modified the milestones: 2023.12.0, 2024.1.0 Nov 28, 2023
pcdavid added a commit that referenced this issue Nov 28, 2023
@pcdavid
[2579] Fix invalid cursor position when typing a new label directly
935b24c 
Bug: #2579
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Nov 28, 2023
Merged
@pcdavid pcdavid linked a pull request Nov 28, 2023 that will close this issue
[2579] Fix invalid cursor position when typing a new label directly #2664
Merged
frouene pushed a commit that referenced this issue Dec 13, 2023
@pcdavid @frouene
[2579] Fix invalid cursor position when typing a new label directly
5547a60 
Bug: #2579
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 14, 2023
@pcdavid @frouene
[2579] Fix invalid cursor position when typing a new label directly
988f7a5 
Bug: #2579
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 14, 2023
@pcdavid @frouene
[2579] Fix invalid cursor position when typing a new label directly
5350bad 
Bug: #2579
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 14, 2023
@pcdavid @frouene
[2579] Fix invalid cursor position when typing a new label directly
40ec080 
Bug: #2579
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 14, 2023
@pcdavid @frouene
[2579] Fix invalid cursor position when typing a new label directly
2c8812a 
Bug: #2579
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2024.1.0
Development

Successfully merging a pull request may close this issue.

[2579] Fix invalid cursor position when typing a new label directly eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau