Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the creation of a node at the palette location for a custom tool #2581

Closed
frouene opened this issue Nov 15, 2023 · 1 comment · Fixed by #2632 or #2734
Closed

Allow the creation of a node at the palette location for a custom tool #2581

frouene opened this issue Nov 15, 2023 · 1 comment · Fixed by #2632 or #2734
Assignees
@frouene
Labels
difficulty: medium package: diagrams
Milestone
2023.12.0

Comments

@frouene
Copy link
Contributor

frouene commented Nov 15, 2023

Currently, when a new node is created by a custom tool, it is not created at the click location, but at a default position.
Offer the possibility of applying the same behavior as for classic node tools.

Expected behavior

node_position

Actual behavior

node_position_actual
@frouene frouene added this to the 2023.12.0 milestone Nov 15, 2023
@frouene frouene self-assigned this Nov 15, 2023
frouene added a commit that referenced this issue Nov 24, 2023
@frouene
[2581] Allow custom tools to control their creation position
97e7136 
Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Nov 24, 2023
@frouene
[2581] Allow custom tools to control their creation position
519f962 
Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene mentioned this issue Nov 24, 2023
Merged
39 tasks
pcdavid pushed a commit that referenced this issue Nov 27, 2023
@frouene @pcdavid
[2581] Allow custom tools to control their creation position
ce86f5b 
Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
pcdavid pushed a commit that referenced this issue Nov 27, 2023
@frouene @pcdavid
[2581] Allow custom tools to control their creation position
ffd8126 
Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
pcdavid pushed a commit that referenced this issue Nov 27, 2023
@frouene @pcdavid
[2581] Allow custom tools to control their creation position
a7a7fcc 
Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene linked a pull request Nov 28, 2023 that will close this issue
[2581] Allow custom tools to control their creation position #2632
Merged
39 tasks
@frouene frouene closed this as completed Nov 28, 2023
@frouene
Copy link
Contributor Author

frouene commented Dec 5, 2023

With this commit the way the reference position is set has changed and a new API must be added to allow custom tool to contribute their own reference position.

@frouene frouene reopened this Dec 5, 2023
frouene added a commit that referenced this issue Dec 5, 2023
@frouene
[2581] Add a new API to provide a reference position handler for cust…
5d915e6 
…om tool

Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene mentioned this issue Dec 5, 2023
Merged
39 tasks
@frouene frouene linked a pull request Dec 5, 2023 that will close this issue
[2581] Add a new API to provide a reference position handler for cust… #2734
Merged
39 tasks
frouene added a commit that referenced this issue Dec 5, 2023
@frouene
[2581] Add a new API to provide a reference position handler for cust…
659464e 
…om tool

Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Dec 5, 2023
@frouene @sbegaudeau
[2581] Add a new API to provide a reference position handler for cust…
aae6c6d 
…om tool

Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Dec 5, 2023
@frouene @sbegaudeau
[2581] Add a new API to provide a reference position handler for cust…
b4affc1 
…om tool

Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Dec 6, 2023
@frouene @sbegaudeau
[2581] Add a new API to provide a reference position handler for cust…
99127e7 
…om tool

Bug: #2581
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouene frouene

Labels
difficulty: medium package: diagrams
Projects
None yet
Milestone
2023.12.0
1 participant
@frouene