Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback during edge creation #2584

Closed
pcdavid opened this issue Nov 16, 2023 · 1 comment · Fixed by #2585
Closed

Add feedback during edge creation #2584

pcdavid opened this issue Nov 16, 2023 · 1 comment · Fixed by #2585

Comments

@pcdavid
Copy link
Member

pcdavid commented Nov 16, 2023

As mentioned in the corresponding shape:

During the edge creation or reconnection process (the user is dragging a connection line from its source to the wanted target):

  • nodes which are known to be incompatible with any kind of edge creation tool starting from the source are temporarily faded;
  • when the mouse cursor hovers on a compatible target node, that node is highlighted (using the same style as uses for node DnD);
  • nodes (compatible but not hovered) which where not faded by the user keep their style
  • nodes (compatible but not hovered) which where faded by the user are temporarily unfaded to indicate they are compatible.
@pcdavid pcdavid added this to the 2023.12.0 milestone Nov 16, 2023
@pcdavid pcdavid self-assigned this Nov 16, 2023
pcdavid added a commit that referenced this issue Nov 16, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 16, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 17, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 20, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Nov 20, 2023 that will close this issue
@pcdavid pcdavid changed the title Add feedback during edge creation and reconnection Add feedback during edge creation Nov 20, 2023
@pcdavid
Copy link
Member Author

pcdavid commented Nov 20, 2023

Only edge creation will be handled in this issue. Edge reconnection requires more work and will be done later.

pcdavid added a commit that referenced this issue Nov 20, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
mcharfadi pushed a commit that referenced this issue Nov 20, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 20, 2023
Bug: #2584
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant