Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some padding the PageAction #2600

Closed
adaussy opened this issue Nov 20, 2023 · 1 comment · Fixed by #2719
Closed

Add some padding the PageAction #2600

adaussy opened this issue Nov 20, 2023 · 1 comment · Fixed by #2719
Assignees
@pcdavid
Labels
difficulty: medium package: forms type: bug
Milestone
2023.12.0

Comments

@adaussy
Copy link
Contributor

adaussy commented Nov 20, 2023

The page action buttons overlaps the Page bottom bar.

image

The icon should be smaller to avoid this effect.
@sbegaudeau
Copy link
Member

The padding should probably be in the page showing both the navigation bar and the groups.

@pcdavid pcdavid mentioned this issue Dec 1, 2023
Merged
pcdavid added a commit that referenced this issue Dec 1, 2023
@pcdavid
[2600] Add a small margin at the top of a page
eda52b7 
This helps delineate the page's tab from the content, in particular
when the page contains action buttons.

Bug: #2600
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid modified the milestones: 2024.1.0, 2023.12.0 Dec 1, 2023
@pcdavid pcdavid linked a pull request Dec 1, 2023 that will close this issue
[2600] Add a small margin at the top of a page #2719
Merged
@pcdavid pcdavid self-assigned this Dec 1, 2023
sbegaudeau pushed a commit that referenced this issue Dec 1, 2023
@pcdavid @sbegaudeau
[2600] Add a small margin at the top of a page
bfa93f5 
This helps delineate the page's tab from the content, in particular
when the page contains action buttons.

Bug: #2600
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 1, 2023
@pcdavid @sbegaudeau
[2600] Add a small margin at the top of a page
3b8fc59 
This helps delineate the page's tab from the content, in particular
when the page contains action buttons.

Bug: #2600
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: forms type: bug
Projects
None yet
Milestone
2023.12.0
Development

Successfully merging a pull request may close this issue.

[2600] Add a small margin at the top of a page eclipse-sirius/sirius-web
3 participants
@pcdavid @sbegaudeau @adaussy