Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram selection is not synchronized with Explorer selection #2613

Closed
4 tasks done
jessymallet opened this issue Nov 21, 2023 · 2 comments
Closed
4 tasks done

Diagram selection is not synchronized with Explorer selection #2613

jessymallet opened this issue Nov 21, 2023 · 2 comments

Comments

@jessymallet
Copy link

When a node is selected, the palette tool appears systematically in ReactFlow. User can close the palette with "echap" (see #2552) but the node is then deselected. This behavior is weird because the semantic element is still selected in Explorer view and because Properties view still display properties about this element.

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version : 2023.10.6
  • I have specified my environment : Window 11

Screenshots

synchSelectionDiagram

Steps to reproduce

1- Open project with entity domain
2- Select an entity node on the diagram
3- Press "Echap" : the node is deselected

Expected behavior

The node should be still selected in order to be coherent with selection in explorer view and in Properties view.

Actual behavior

The node is deselected.

@sbegaudeau
Copy link
Member

The node should be still selected in order to be coherent with selection in explorer view and in Properties view.

We could also remove the node from the selection of the workbench... I don't have an opinion on either solution, whatever is the easiest to implement.

@frouene frouene self-assigned this Nov 30, 2023
@sbegaudeau sbegaudeau modified the milestones: 2023.12.0, 2024.1.0 Dec 5, 2023
frouene added a commit that referenced this issue Dec 18, 2023
Bug: #2613
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@sbegaudeau sbegaudeau removed this from the 2024.1.0 milestone Jan 23, 2024
@sbegaudeau sbegaudeau assigned gcoutable and unassigned frouene Jan 23, 2024
@sbegaudeau sbegaudeau added this to the 2024.3.0 milestone Jan 23, 2024
gcoutable added a commit that referenced this issue Feb 13, 2024
Bug: #2613
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable
Copy link
Contributor

This issue is fixed on sirius web2024.3.0
It seems #3044 has fixed it.

@gcoutable gcoutable linked a pull request Mar 25, 2024 that will close this issue
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants