Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node handles are always on right or left #2640

Closed
gcoutable opened this issue Nov 27, 2023 · 2 comments · Fixed by #2641
Closed

Node handles are always on right or left #2640

gcoutable opened this issue Nov 27, 2023 · 2 comments · Fixed by #2641

Comments

@gcoutable
Copy link
Contributor

No description provided.

@gcoutable
Copy link
Contributor Author

Initially handles were initialized on the left and the right of nodes every time a refresh event payload was received, which was happening rarely.
Since #2262 we share the position and size of nodes between all opened diagram instances which implies a diagram refresh payload for all opened diagrams on every change, and thus, always initializes node handle position to the left and right of nodes

@gcoutable
Copy link
Contributor Author

gcoutable commented Nov 27, 2023

The first thing to do will be to execute the algorithm that sets the position of handles on the conversion.

gcoutable added a commit that referenced this issue Nov 27, 2023
Bug: #2640
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
gcoutable added a commit that referenced this issue Nov 27, 2023
Bug: #2640
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@gcoutable gcoutable linked a pull request Nov 27, 2023 that will close this issue
39 tasks
gcoutable added a commit that referenced this issue Nov 28, 2023
Bug: #2640
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 28, 2023
Bug: #2640
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Nov 28, 2023
Bug: #2640
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant