Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated colors for navigation bar in Sirius Web theme #2658

Closed
1 task done
AxelRICHARD opened this issue Nov 28, 2023 · 0 comments · Fixed by #2674
Closed
1 task done

Add dedicated colors for navigation bar in Sirius Web theme #2658

AxelRICHARD opened this issue Nov 28, 2023 · 0 comments · Fixed by #2674
Assignees
@AxelRICHARD
Labels
difficulty: starter package: sirius web type: enhancement
Milestone
2024.1.0

Comments

@AxelRICHARD
Copy link
Contributor

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

Today, the navigation bar border color is the theme.primary.main color.
The navigation bar background color is the theme.primary.secondary color.
theme.primary.main and theme.primary.secondary colors are also used for many others parts in the UI.

An enhancement could be to add dedicated colors properties for the navigation colors in the Sirius Web theme.

Cuttings backs

...

Potential side effects

...

Describe alternatives you've considered

...
@AxelRICHARD AxelRICHARD added this to the 2024.1.0 milestone Nov 28, 2023
@AxelRICHARD AxelRICHARD self-assigned this Nov 28, 2023
AxelRICHARD added a commit that referenced this issue Nov 28, 2023
@AxelRICHARD
[2658] Add dedicated colors for navigation bar in Sirius Web theme
be0f2f8 
Bug: #2658
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD mentioned this issue Nov 28, 2023
Closed
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Nov 28, 2023 that will close this issue
[2658] Add dedicated colors for navigation bar in Sirius Web theme #2661
Closed
39 tasks
@sbegaudeau sbegaudeau linked a pull request Dec 6, 2023 that will close this issue
[2672] [2669] [2658] Improve the Sirius Web theme by allowing more customization #2674
Merged
39 tasks
sbegaudeau pushed a commit that referenced this issue Dec 6, 2023
@AxelRICHARD @sbegaudeau
[2658] Add dedicated colors for the navigation bar in the theme
d5c7c2e 
Bug: #2658
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
AxelRICHARD added a commit that referenced this issue Dec 6, 2023
@AxelRICHARD
[2658] Add dedicated colors for the navigation bar in the theme
933fdf3 
Bug: #2658
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 8, 2023
@AxelRICHARD @sbegaudeau
[2658] Add dedicated colors for the navigation bar in the theme
ee90a35 
Bug: #2658
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Dec 8, 2023
@AxelRICHARD @sbegaudeau
[2658] Add dedicated colors for the navigation bar in the theme
07b364b 
Bug: #2658
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
difficulty: starter package: sirius web type: enhancement
Projects
None yet
Milestone
2024.1.0
1 participant
@AxelRICHARD