Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default colors are not applied to sub-nodes and border nodes #2943

Closed
pcdavid opened this issue Jan 17, 2024 · 0 comments · Fixed by #2946
Closed

Default colors are not applied to sub-nodes and border nodes #2943

pcdavid opened this issue Jan 17, 2024 · 0 comments · Fixed by #2946
Assignees
@AxelRICHARD
Labels
package: diagrams type: bug
Milestone
2024.1.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 17, 2024

Steps to reproduce:

  1. Create a blank studio
  2. Create a View
  3. Inside the DiagramDescription, create a NodeDescription.
  4. Its style is a RectangularNodeStyleDescription, with propertly initialized background/border/label colors.
  5. Create a sub-node inside of it.
  6. Its style is a RectangularNodeStyleDescription, but its colors are not initialized.
  7. Same with a border node of the top-level node, or any other level ob sub/border nodes.

Only the nodes added directly inside a DiagramDescription are handled by DiagramColorAdapter.
AxelRICHARD added a commit that referenced this issue Jan 17, 2024
@AxelRICHARD
[2943] Fix default colors for View sub-nodes and border nodes
a65be22 
Bug: #2943
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD AxelRICHARD mentioned this issue Jan 17, 2024
Merged
39 tasks
@AxelRICHARD AxelRICHARD linked a pull request Jan 17, 2024 that will close this issue
[2943] Fix default colors for View sub-nodes and border nodes #2946
Merged
39 tasks
@AxelRICHARD AxelRICHARD added this to the 2024.1.0 milestone Jan 17, 2024
@AxelRICHARD AxelRICHARD self-assigned this Jan 17, 2024
pcdavid pushed a commit that referenced this issue Jan 18, 2024
@AxelRICHARD @pcdavid
[2943] Fix default colors for View sub-nodes and border nodes
4f6d4f8 
Bug: #2943
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AxelRICHARD AxelRICHARD

Labels
package: diagrams type: bug
Projects
None yet
Milestone
2024.1.0
Development

Successfully merging a pull request may close this issue.

[2943] Fix default colors for View sub-nodes and border nodes eclipse-sirius/sirius-web
2 participants
@pcdavid @AxelRICHARD