Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's difficult to distinguish connection line from edges #2951

Closed
mcharfadi opened this issue Jan 18, 2024 · 0 comments · Fixed by #2954
Closed

It's difficult to distinguish connection line from edges #2951

mcharfadi opened this issue Jan 18, 2024 · 0 comments · Fixed by #2954
Assignees
@mcharfadi
Labels
difficulty: starter package: diagrams type: enhancement
Milestone
2024.3.0

Comments

@mcharfadi
Copy link
Contributor

mcharfadi commented Jan 18, 2024 •
edited

ConnectionLine and the temporary edge used when there are multiples connection possible are difficult to distinguish from edges.
We should use the theme.selected color to distinguish them.
@mcharfadi mcharfadi self-assigned this Jan 18, 2024
@mcharfadi mcharfadi added this to the 2024.3.0 milestone Jan 18, 2024
mcharfadi added a commit that referenced this issue Jan 18, 2024
@mcharfadi
[2951] Set ConnectionLine color to palette.selected
901e954 
Bug: #2951
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
mcharfadi added a commit that referenced this issue Jan 18, 2024
@mcharfadi
[2951] Set ConnectionLine color to palette.selected
b52251f 
Bug: #2951
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
@mcharfadi mcharfadi mentioned this issue Jan 18, 2024
Merged
39 tasks
@mcharfadi mcharfadi linked a pull request Jan 18, 2024 that will close this issue
[2951] Set ConnectionLine color to palette.selected #2954
Merged
39 tasks
mcharfadi added a commit that referenced this issue Jan 18, 2024
@mcharfadi
[2951] Set ConnectionLine color to palette.selected
bbef67a 
Bug: #2951
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
frouene pushed a commit that referenced this issue Jan 22, 2024
@mcharfadi @frouene
[2951] Set ConnectionLine color to palette.selected
ee87b30 
Bug: #2951
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
frouene pushed a commit that referenced this issue Jan 22, 2024
@mcharfadi @frouene
[2951] Set ConnectionLine color to palette.selected
00da65e 
Bug: #2951
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
frouene pushed a commit that referenced this issue Jan 22, 2024
@mcharfadi @frouene
[2951] Set ConnectionLine color to palette.selected
05b1f7e 
Bug: #2951
Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcharfadi mcharfadi

Labels
difficulty: starter package: diagrams type: enhancement
Projects
None yet
Milestone
2024.3.0
Development

Successfully merging a pull request may close this issue.

[2951] Set ConnectionLine color to palette.selected eclipse-sirius/sirius-web
1 participant
@mcharfadi