Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic drop is only available on ListNode or RectangularNode #3100

Closed
frouene opened this issue Feb 13, 2024 · 1 comment · Fixed by #3104
Closed

Semantic drop is only available on ListNode or RectangularNode #3100

frouene opened this issue Feb 13, 2024 · 1 comment · Fixed by #3104
Assignees
@frouene
Labels
difficulty: starter package: diagrams type: enhancement
Milestone
2024.3.0

Comments

@frouene
Copy link
Contributor

frouene commented Feb 13, 2024

Expected behavior

It should be possible to perform a semantic drop in every node, even if the target node is not a natural container like IconLabel for example.

Actual behavior

The semantic drop is only defined on ListNode and RectangularNode, for other node type, the diagramTargetElementId use in the drop mutation is the one from the diagram
@frouene frouene added this to the 2024.3.0 milestone Feb 13, 2024
@frouene
Copy link
Contributor Author

frouene commented Feb 14, 2024

The PR #2817 implicitly added the drop on the imageNode (now FreeFormNode)

frouene added a commit that referenced this issue Feb 14, 2024
@frouene
[3100] Add support for drop on IconLabelNode
0fe5fa9 
Bug: #3100
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene self-assigned this Feb 14, 2024
@frouene frouene mentioned this issue Feb 14, 2024
Merged
39 tasks
@frouene frouene linked a pull request Feb 14, 2024 that will close this issue
[3100] Add support for drop on IconLabelNode #3104
Merged
39 tasks
AxelRICHARD pushed a commit that referenced this issue Feb 14, 2024
@frouene @AxelRICHARD
[3100] Add support for drop on IconLabelNode
1d7f104 
Bug: #3100
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouene frouene

Labels
difficulty: starter package: diagrams type: enhancement
Projects
None yet
Milestone
2024.3.0
Development

Successfully merging a pull request may close this issue.

[3100] Add support for drop on IconLabelNode eclipse-sirius/sirius-web
1 participant
@frouene