Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon on edgeTool are never used #3143

Closed
frouene opened this issue Feb 21, 2024 · 1 comment · Fixed by #3148
Closed

Icon on edgeTool are never used #3143

frouene opened this issue Feb 21, 2024 · 1 comment · Fixed by #3148
Assignees
@frouene
Labels
difficulty: medium package: diagrams
Milestone
2024.3.0

Comments

@frouene
Copy link
Contributor

frouene commented Feb 21, 2024

Setting an Icon URLs Expression on edgeTool is never used, and it's always the default svg displayed
@frouene frouene added this to the 2024.3.0 milestone Feb 21, 2024
@frouene frouene self-assigned this Feb 22, 2024
frouene added a commit that referenced this issue Feb 22, 2024
@frouene
[3143] Use Icon URLs Expression to provide EdgeTool icon
22015dc 
Bug: #3143
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene mentioned this issue Feb 22, 2024
Merged
39 tasks
@frouene frouene linked a pull request Feb 22, 2024 that will close this issue
[3143] Use Icon URLs Expression to provide EdgeTool icon #3148
Merged
39 tasks
@frouene
Copy link
Contributor Author

frouene commented Feb 22, 2024

When creating edgeTools, we don't have access to the context for interpreting an AQL query.
In this first correction, we only allow to retrieve a static value.

frouene added a commit that referenced this issue Feb 22, 2024
@frouene
[3143] Use Icon URLs Expression to provide EdgeTool icon
9ae8b19 
Bug: #3143
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
AxelRICHARD pushed a commit that referenced this issue Feb 22, 2024
@frouene @AxelRICHARD
[3143] Use Icon URLs Expression to provide EdgeTool icon
948c223 
Bug: #3143
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouene frouene

Labels
difficulty: medium package: diagrams
Projects
None yet
Milestone
2024.3.0
Development

Successfully merging a pull request may close this issue.

[3143] Use Icon URLs Expression to provide EdgeTool icon eclipse-sirius/sirius-web
1 participant
@frouene