Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precondition on node tool is not respected in some cases #3206

Closed
frouene opened this issue Mar 11, 2024 · 0 comments · Fixed by #3212
Closed

Precondition on node tool is not respected in some cases #3206

frouene opened this issue Mar 11, 2024 · 0 comments · Fixed by #3212
Assignees
@frouene
Labels
difficulty: medium package: diagrams type: bug
Milestone
2024.3.0

Comments

@frouene
Copy link
Contributor

frouene commented Mar 11, 2024

For the following two cases, preconditions are not evaluated on node tool:

  • tool in a tool section for diagram palettes
  • tool not in a tool section for edge palettes
@frouene frouene added this to the 2024.3.0 milestone Mar 11, 2024
@frouene frouene self-assigned this Mar 12, 2024
frouene added a commit that referenced this issue Mar 12, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
98be28e 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene mentioned this issue Mar 12, 2024
Merged
39 tasks
@frouene frouene linked a pull request Mar 12, 2024 that will close this issue
[3206] Add precondition check for edge tool and diagram tool section #3212
Merged
39 tasks
frouene added a commit that referenced this issue Mar 12, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
d09c07e 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Mar 14, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
a0cf4f8 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Mar 18, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
2dc650f 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Mar 19, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
0012491 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Mar 19, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
09b349f 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Mar 19, 2024
@frouene
[3206] Add precondition check for edge tool and diagram tool section
bc5a894 
Bug: #3206
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouene frouene

Labels
difficulty: medium package: diagrams type: bug
Projects
None yet
Milestone
2024.3.0
Development

Successfully merging a pull request may close this issue.

[3206] Add precondition check for edge tool and diagram tool section eclipse-sirius/sirius-web
1 participant
@frouene