Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a common identification strategy for transient representations #3303

Closed
sbegaudeau opened this issue Mar 30, 2024 · 1 comment · Fixed by #3336
Closed

Use a common identification strategy for transient representations #3303

sbegaudeau opened this issue Mar 30, 2024 · 1 comment · Fixed by #3336
Assignees
@pcdavid
Labels
difficulty: medium package: sirius web type: architecture
Milestone
2024.5.0

Comments

@sbegaudeau
Copy link
Member

We need to be able to identify clearly if an instance of a representation is transient or not. For that, applications contributing representations should use the same identification strategy to let us find out if a representation is transient or not.

See the ADR 137 for additional details.
@sbegaudeau sbegaudeau added this to the 2024.5.0 milestone Mar 30, 2024
@sbegaudeau sbegaudeau mentioned this issue Mar 30, 2024
Closed
@sbegaudeau
Copy link
Member Author

On top of aligning the representationId, we should probably add some capabilities to contribute RepresentationMetadata properly for those representations. In the past we had to hardcode some representation metadata for the explorer for example but this use case will have to be properly supported.

A new ADR would probably be required to details very quickly how to proceed

@pcdavid pcdavid self-assigned this Apr 2, 2024
pcdavid added a commit that referenced this issue Apr 4, 2024
@pcdavid
[3303] Add ADR for contributing representation metadata for transient…
cdcd2df 
… representations

Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Apr 4, 2024
Merged
pcdavid added a commit that referenced this issue Apr 5, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
bddefd7 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 5, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
edf4dc4 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 5, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
179cd3d 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 9, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
431471b 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 9, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
9311497 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 10, 2024
@pcdavid @sbegaudeau
[3303] Add ADR for contributing representation metadata for transient…
f6fcae3 
… representations

Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 10, 2024
@pcdavid @sbegaudeau
[3303] Add ADR for contributing representation metadata for transient…
0f8a883 
… representations

Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 10, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
bd42cec 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Apr 12, 2024 that will close this issue
[3303] Use common identification strategy for transient representations #3336
Merged
@sbegaudeau sbegaudeau mentioned this issue Apr 14, 2024
Merged
39 tasks
pcdavid added a commit that referenced this issue Apr 15, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
2755fe4 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 17, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
fa90149 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 17, 2024
@pcdavid
[3303] Reduce the expected coverage to get the e2e results
db923ee 
This is a temporary commit to get the e2e results from the CI while
working on actually improving the coverage.

Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 17, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
7cb772e 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 18, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
748ce54 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Apr 24, 2024
@pcdavid
[3303] Use common identification strategy for transient representations
1d3638f 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 25, 2024
@pcdavid @sbegaudeau
[3303] Use common identification strategy for transient representations
d789c43 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 25, 2024
@pcdavid @sbegaudeau
[3303] Use common identification strategy for transient representations
b36f20c 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 25, 2024
@pcdavid @sbegaudeau
[3303] Use common identification strategy for transient representations
c7ad059 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 25, 2024
@pcdavid @sbegaudeau
[3303] Use common identification strategy for transient representations
45ecebf 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Apr 25, 2024
@pcdavid @sbegaudeau
[3303] Use common identification strategy for transient representations
f22d411 
Bug: #3303
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: sirius web type: architecture
Projects
None yet
Milestone
2024.5.0
Development

Successfully merging a pull request may close this issue.

[3303] Use common identification strategy for transient representations eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau