New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1305] Fix update of the default tools of the palette's tool sections #2001
Conversation
058a06c
to
5ceb972
Compare
Cypress test seems unpredictable, need to find an alternative. |
5ceb972
to
a24c575
Compare
@@ -14,5 +14,6 @@ import { GQLTool, GQLToolSection } from '../ContextualPalette.types'; | |||
|
|||
export interface ToolSectionProps { | |||
toolSection: GQLToolSection; | |||
defaultToolId: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, either you want to explicitly handle nothing as an explicit value and in this case use string | null
but if you want to provide an optional prop on a component you should probably use defaultToolId?: string
. With this, you do not have to specify <ToolSection defaultToolId={undefined} />
which is not very sexy.
Most of the time, I prefer that we handle explicitly null values but for the props of a component, an optional prop is perfectly fine. It works the same for simple boolean-based props for example to be able to have something like this:
<Something />
<Something />
<Something disabled />
<Something />
And not
<Something disabled={false} />
<Something disabled={false} />
<Something disabled={true} />
<Something disabled={false} />
Bug: #1305 Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
a24c575
to
3e78336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge it once the build is green
Bug: #1305
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request