Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add ADR for dynamic widgets support in Forms #2240

Merged
merged 2 commits into from Aug 25, 2023

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Aug 10, 2023

Known issues which needs to be addressed:

  • Now that a single WidgetDescription can produce 0, 1 or many instances, the widgets' id, as provided by the WidgetIdCounter, can not be relied upon. Between two successive renders of the same Form, the widget with id #4 can be completely different ones (different instances of the same widget description, or instance of completely different widgets; maybe of the same kind maybe not).
  • FormDescriptionEditor support: rendering is easy, but the result does not actually support all the FDE operations (add/remove/move widgets). A FormDescriptionEditor normally display a plain Form instance, with the actual widgets rendered on sample/preview data, but DynamicFor & DynamicIf, while they exist on the FormDescription, do not exist as widgets in the actual rendered Form. I guess it would be possible to create dedicated widgets for them (rendered how? as containers?) and only render them when some flag/variable is present, but that makes the core Form dialect know about a "special mode" just for the FDE).

pcdavid and others added 2 commits August 25, 2023 08:56
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau merged commit a218af2 into master Aug 25, 2023
4 checks passed
@sbegaudeau sbegaudeau deleted the pcd/doc/adr-dynamic-widgets branch August 25, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants