New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2288] Make IconLabel a react flow node #2305
Conversation
5314e5f
to
01a5d51
Compare
01a5d51
to
364ccb8
Compare
packages/diagrams/frontend/sirius-components-diagrams-reactflow/src/renderer/layout/layout.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could precise the node.extent to avoid the node being moved at the same position as the label of the parent node.
8677b6d
to
1504b35
Compare
With #288 node will be able to move anywhere, so, I think the |
I'm not able to hide the Icon Label Nodes, if we can't hide them we should not have the action in the toolbar. |
1504b35
to
2fdc6c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small issue regarding layout when hiding all the IconLabel of a node
https://github.com/eclipse-sirius/sirius-web/assets/121878084/446a8af6-27c3-4b42-a528-8ce8467d6001
A fix to that issue is included in the next PR. |
7b30bdb
to
062c9fe
Compare
062c9fe
to
9e2c363
Compare
9e2c363
to
75de2f1
Compare
305015a
to
2c442c6
Compare
Bug: #2288 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
2c442c6
to
52bbc9f
Compare
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request