New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2978] Add useCallback to ReactFlow edge & drag events #2979
Conversation
1b90bb1
to
3ae3f71
Compare
3ae3f71
to
4730606
Compare
4730606
to
1d747fa
Compare
@@ -102,8 +89,11 @@ export const useDrop = (): UseDropValue => { | |||
if (data === '') { | |||
return; | |||
} | |||
const dropPosition = reactflow.screenToFlowPosition({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nodes are not dropped where I am expecting it at all. Please fix this part of restore the old code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I had changes in my stash that I missed to push sorry
The dependency of the useCallback should have been reactflow
. I took the example from there
I pushed an update.
const onNodeDragStop: (onDragCancelled: (node: Node) => void) => NodeDragHandler = useCallback( | ||
(onDragCancelled) => { | ||
return (event, _node) => { | ||
const dropPosition = computeDropPosition(event, viewport, element); | ||
const dropPosition = reactflow.screenToFlowPosition({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested that yet but since the other code had a bug, I have the feeling that it does not what you think it does.
1d747fa
to
fe32098
Compare
Bug: #2978 Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
fe32098
to
156392b
Compare
Bug: #2978
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request