-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3424] Fix document migration data during creation #3427
Conversation
983f5d4
to
be4b7e2
Compare
@@ -35,7 +35,7 @@ | |||
@Service | |||
public class NodeDescriptionLabelExpressionMigrationParticipant implements IMigrationParticipant { | |||
|
|||
private static final String PARTICIPANT_VERSION = "2024.4.0"; | |||
private static final String PARTICIPANT_VERSION = "2024.3.2.22.0.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somehow missed that but we discussed in details about the shape that was expected for the migration participant version and I don't understand what this is supposed to be (what is this 22 for example?). I don't know what this is supposed to be. I need an iteration, a date and some time, something like this 2024.8.0-202407121400
. It needs to be more specific in the ADR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the ADR in order to be more precise about the version of participants
@@ -37,6 +41,12 @@ public class DefaultDomainResourceProvider implements IDefaultDomainResourceProv | |||
|
|||
private static final String DOMAIN_DOCUMENT_NAME = "DomainNewModel"; | |||
|
|||
private final List<IMigrationParticipant> migrationParticipants; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not be viable in the long run to ask everybody to get injected with this every time they want to create a new resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would setting the correct migrationData in StudioProjectTemplateInitializer
be more acceptable then ?
...rc/main/java/org/eclipse/sirius/web/application/studio/services/StudioStereotypeHandler.java
Outdated
Show resolved
Hide resolved
f344515
to
91d1e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this tiny detail and merge it
...ditingcontext/migration/participants/NodeDescriptionLabelExpressionMigrationParticipant.java
Outdated
Show resolved
Hide resolved
91d1e45
to
180c976
Compare
I'll wait for the build and merge it just after |
Bug: #3424 Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
180c976
to
c9c69ec
Compare
Bug: #3424
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:
andpr:
labels been added to the pull request? (In case of doubt, start with the labelspriority: low
andpr: to review later
)area:
,difficulty:
,type:
)CHANGELOG.adoc
been updated to reference the relevant issues?CHANGELOG.adoc
? (Including changes in the GraphQL API)CHANGELOG.adoc
? For example indoc/screenshots/2022.5.0-my-new-feature.png
Architectural decision records (ADR)
[doc]
?CHANGELOG.adoc
?Dependencies
CHANGELOG.adoc
?CHANGELOG.adoc
?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
useState<STATE_TYPE>(…)
?.
(if the GraphQL API specifies that a field cannot benull
, do not treat it has potentiallynull
for example)let diagram: Diagram | null = null;
)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request