Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to use "external" ASM #83

Closed
cstamas opened this issue Apr 5, 2023 · 4 comments
Closed

Ability to use "external" ASM #83

cstamas opened this issue Apr 5, 2023 · 4 comments

Comments

@cstamas
Copy link
Member

cstamas commented Apr 5, 2023

To prevent being locked...

Could we do something similar like explained here?
google/guice#1657 (comment)

I know this is "tailored" to Maven, but actually, would be cool for all sisu using projects, as one could freely update ASM... as in Maven ASM is anyway "sealed" off.
@kwin
Copy link
Contributor

kwin commented Apr 5, 2023

We couldn’t agree on automatically embedding (and relocating) as part of the build in #72 (comment). IIUC this would be a prerequisite for this feature.

@slachiewicz slachiewicz mentioned this issue Apr 5, 2023
Closed
@slachiewicz
Copy link
Contributor

Ok so looks it works 6ecaaea

@mcculls
Copy link
Contributor

mcculls commented Apr 8, 2023

#86 will add a "no_asm" variant for each release, allowing users to change the ASM version between releases without affecting other users that prefer having ASM embedded.

@cstamas
Copy link
Member Author

cstamas commented Jun 16, 2023

Solved in .0.9.0.M2

@cstamas cstamas closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cstamas @mcculls @kwin @slachiewicz