Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions to conform to javax->jakarta.inject namespace change #85

Closed
wants to merge 1 commit into from

Conversation

NiklasRentzCAU
Copy link
Contributor

As the javax namespace is currently being phased out in newer releases, Sprotty should also jump on the train and replace old javax dependencies to work together with newer releases. Especially the latest Google Guice (com.google.inject) 7.0 release completely changes over from javax.inject to jakarta.inject dependencies, thus breaking the dependency injection of Sprotty when combined with newer versions.

In this PR I upgraded some dependencies to be more in line with the latest Eclipse 2023-09 release, especially the dependency injection framework.

I tried also updating the Java build version from 1.8 to 11, which caused unexpected build errors and Xtext and LSP4J to newer versions, which caused unexpected test errors (thrown exceptions because JUnit did not find any but expected tests in the TestLanguage classes).

This is a start to fix the injection issues with newer versions. To fully fix the problem with injecting the correct instances into extensions of the DefaultDiagramServer class with bindings in an extension to the DefaultDiagramModule class, the Xtext version probably needs to be updated as well.

What do you think of clearing up and updating the versions to release a new Sprotty server component soon? Currently in KLighD I have to resort to a workaround by re-injecting all fields of the DefaultDiagramServer so that it uses the correct injection framework namespace again.

@NiklasRentzCAU NiklasRentzCAU added the enhancement New feature or request label Nov 9, 2023
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, there's a lot more to be updated, including the example project.

If we want to publish a new release (v1.0.0), we'd need to sort out how. The last one used infrastructure that is no longer available.

@spoenemann
Copy link
Contributor

We forgot to merge this after approval. The changes are now included in #87.

@spoenemann spoenemann closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants