update versions to conform to javax->jakarta.inject namespace change #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the javax namespace is currently being phased out in newer releases, Sprotty should also jump on the train and replace old javax dependencies to work together with newer releases. Especially the latest Google Guice (com.google.inject) 7.0 release completely changes over from javax.inject to jakarta.inject dependencies, thus breaking the dependency injection of Sprotty when combined with newer versions.
In this PR I upgraded some dependencies to be more in line with the latest Eclipse 2023-09 release, especially the dependency injection framework.
I tried also updating the Java build version from 1.8 to 11, which caused unexpected build errors and Xtext and LSP4J to newer versions, which caused unexpected test errors (thrown exceptions because JUnit did not find any but expected tests in the TestLanguage classes).
This is a start to fix the injection issues with newer versions. To fully fix the problem with injecting the correct instances into extensions of the
DefaultDiagramServer
class with bindings in an extension to theDefaultDiagramModule
class, the Xtext version probably needs to be updated as well.What do you think of clearing up and updating the versions to release a new Sprotty server component soon? Currently in KLighD I have to resort to a workaround by re-injecting all fields of the
DefaultDiagramServer
so that it uses the correct injection framework namespace again.