Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] get rid of constructor injection #59

Closed
JanKoehnlein opened this issue Feb 12, 2019 · 0 comments
Closed

[api] get rid of constructor injection #59

JanKoehnlein opened this issue Feb 12, 2019 · 0 comments
Milestone
v0.6.0

Comments

@JanKoehnlein
Copy link
Contributor

Constructor injection induces much more API breaks than necessary. We should prefer property injection whenever applicable.
JanKoehnlein added a commit that referenced this issue Feb 12, 2019
@JanKoehnlein
#59 switched to property injection
873363e 
In all cases but
- registrations
- actions in commands

Fixes #59
JanKoehnlein added a commit that referenced this issue Feb 14, 2019
@JanKoehnlein
#59 switched to property injection
88ae3e6 
In all cases but
- registrations
- actions in commands

Fixes #59
@JanKoehnlein JanKoehnlein mentioned this issue Feb 14, 2019
Merged
JanKoehnlein added a commit that referenced this issue Feb 14, 2019
@JanKoehnlein
#59 switched to property injection
f4ec94b 
In all cases but
- registrations
- actions in commands

Fixes #59
JanKoehnlein added a commit that referenced this issue Feb 15, 2019
@JanKoehnlein
#59 switched to property injection
d959833 
In all cases but
- registrations
- actions in commands

Fixes #59
JanKoehnlein added a commit that referenced this issue Feb 15, 2019
@JanKoehnlein
\#59 switched to property injection
a39f8ce 
In all cases but
- registrations
- actions in commands
- don't use @PostConstruct

Fixes #59
JanKoehnlein added a commit that referenced this issue Feb 15, 2019
@JanKoehnlein
#59 switched to property injection
a3ac469 
In all cases but
- registrations
- actions in commands
- don't use @PostConstruct

Fixes #59
JanKoehnlein added a commit that referenced this issue Feb 15, 2019
@JanKoehnlein
#59 switched to property injection
d80c41c 
In all cases but
- registrations
- actions in commands

Don't use @PostConstruct. Fixed tests

Fixes #59
JanKoehnlein added a commit that referenced this issue Feb 15, 2019
@JanKoehnlein
#59 switched to property injection
93b85c5 
In all cases but
- registrations
- actions in commands

Don't use @PostConstruct. Fixed tests

Fixes #59
@spoenemann spoenemann added this to the v0.5.0 milestone Feb 18, 2019
JanKoehnlein added a commit to TypeFox/theia-xtext-sprotty-example that referenced this issue Feb 18, 2019
@JanKoehnlein
[api] adapted to latest changes in sprotty
f53308a 
- eclipse-sprotty/sprotty#58
- eclipse-sprotty/sprotty#49
- eclipse-sprotty/sprotty#59
@spoenemann spoenemann mentioned this issue Feb 20, 2019
Merged
@tortmayr tortmayr mentioned this issue Nov 14, 2019
Merged
username123wy pushed a commit to username123wy/theia that referenced this issue Apr 27, 2020
@JanKoehnlein @username123wy
[api] adapted to latest changes in sprotty
4079858 
- eclipse-sprotty/sprotty#58
- eclipse-sprotty/sprotty#49
- eclipse-sprotty/sprotty#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
2 participants
@JanKoehnlein @spoenemann