Flowchart library #423
Merged
Flowchart library #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
spoenemann
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Great!
Remark about the previously merged #416: I think examples/flowchart/src/model-source.ts is not necessary. You can simply pass the model in to the updateModel call in standalone.ts.
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
spoenemann
reviewed
Feb 21, 2024
Signed-off-by: Guillaume Fontorbe <guillaume.fontorbe@typefox.io>
|
Added a more specific model element for each element in the container. We can replace that when we have a free form anchor computation in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new package
sprotty-librarywhich serves as a collection of views with the aim of making easier to start a diagramming solution based on widely used diagrams.The first part of the new package implements views and interfaces for dealing with flowchart diagrams.
It also provides an inversify
ContainerModulewhere node and edges types are link to the provided views.