Add new mode for editing right of way at priority junctions

[namdre]

• hotkey 'w'
• similar to connection mode:
• when entering mode, enable show-connections
• color legend as described below
• first click selects a connection
  • connections that intersect are highlighted:
  • dark green for those which yield to the selected
  • red for those with priority over the selected
• second click on any intersecting connection toggles right-of-way
• buttons ok/cancel
• button 'reset' (resets to default right of way)

Currently, right-of-way can only be configured via xml inputs with a mix of

• edge priority
• connection attribute 'pass'
• prohibitions

It is probably not possible to map arbitrary right of way rules to the above 3 mechanisms. In that case, there would need to be extensions to the plain-xml format and to the way right-of-way logic is handled in NBRequest.

The first step is to lay the netconvert groundwork (Jakob)
The second step is to implement the new mode in netedit (Pablo)

• default colors when no connection is clicked for a tls junction should not conflict with the mode specific connection colors

[namdre]

@palvarezlopez This is not urgent. I'm just putting in here to get it out of my head.

[m-kro]

I would second this prohibition mode. Sometimes, the guessed yielding is just not what you want. I started coding on a prohibition mode before watching the issue list. For now, it consists only of the color legend as described above (see screenshot):

Is there a way to collaborate and speed up this topic?

[namdre]

I think making the right of way rules visible is good first step and a worthwhile feature all by itself.
If you send a pull request that adds this mode i'll be happy to review and merge it.
The next step is to figure out to which extent the internal structures and the xml input formats need to be extended.
For that it would help if you could provide a few examples where the default right of way rules are incorrect (the original .net.xml file and a snippet of the element as you would prefer it to be).

[namdre]

refinements are need because the currently used methods
node->foes() and node->forbids() do not always reflect the final state of the junctionLogic (see the additional checks in NBRequest::getResponseString and NBRequest::getFoesString).

Furthermore the methods would currently retrieve invalid results for lefthand networks due to the way they are computed (via mirroring twice). A possible solution would be to use the cached logic matrix that is proposed as a fix for #4256

[namdre]

• Right of way mode is now consistent with .net.xml
• Right of way can be customized in detail by setting rightOfWay=edgePriority and then customizing edgePriorities.

@m-kro can you please check whether there are use-cases that you still cannot model with the new capabilities?

[m-kro]

Using the edge priorities gives me strange results. I used the same network excerpt as in the screenshot above.
Using the highest numbers for the main incoming and outgoing edges (top>bottom) still results in mutual conflicts with left-turn bottom>left but also with connections coming from left. The said left turn is not signalized as the traffic light is split across multiple nodes.

[namdre]

Can you attach the network?
Mutual conflicts are created to deal with vehicles stranded on the intersection when their phase ends (the phase that has green afterwards still needs to let such vehicles exit safely).
Is the signal plan for that traffic light the one that will also be used in the simulation? If the signal plan is invalid, the mutual conflicts may be invalid as well.

[m-kro]

Tostmannplatz_Nullfall.net.xml.zip

The screenshot shows the attached intersection whose priority settings have been calculated with the priority attribute. Look at the car turning right just next to the western crossing. There is no pedestrian anywhere, but it just does not leave. After a while, this will block the intersection...

[namdre]

was caused by #5047

[alexdawn]

This would be very useful to handle rights of way on large roundabouts which have conflicting movements:

I would like to be able to make the orange connection yield to the selected

[namdre]

@alexdawn The wrong right-of-way in your network was due to #6496 (now fixed).

[namdre]

@alexdawn By default, the straight-going connection will have right of way. You can change this by editing the turning connection and setting pass=true (depends on #6497)