Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float zero comparison in CFM arrival estimation #5845

Merged
merged 1 commit into from Aug 8, 2019

Conversation

m-kro
Copy link
Contributor

@m-kro m-kro commented Jul 23, 2019

Replaces the direct floating point comparison to 0 inside the CFM arrival estimation with a check against NUMERICAL_EPS.
Signed-off-by: m-kro m.barthauer@t-online.de

Signed-off-by: m-kro <m.barthauer@t-online.de>
@behrisch
Copy link
Contributor

behrisch commented Aug 1, 2019

@m-kro Do you have a small example where it makes a difference?

@m-kro
Copy link
Contributor Author

m-kro commented Aug 2, 2019

This is connected to the ongoing corrections in the SSM device, where the CFM arrival estimation is used. I actually had trouble with a very very small acceleration value. I will need some time to compile a working example.

@behrisch
Copy link
Contributor

behrisch commented Aug 7, 2019

Thanks, it would be great to have one.

@m-kro
Copy link
Contributor Author

m-kro commented Aug 7, 2019

Ok I have found the simulation where I discovered this. It is the one from issue #5527 (initial post) using seed 27. At time 2402.2, the assertion eInfo.foeEstimatedConflictEntryTime > 0. is triggered for the conflict ego "Pkw.28.8" vs. foe "Pkw.32.45". eInfo.foeEstimatedConflictEntryTime is the outcome of the CFM arrival time estimation.

@namdre
Copy link
Contributor

namdre commented Aug 8, 2019

I was unable to reproduce the assertion. However, the change looks reasonable enough and does not break any tests so I'm merging it anyway.

@namdre namdre merged commit 94d7016 into eclipse-sumo:master Aug 8, 2019
@m-kro m-kro deleted the numerical branch September 3, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants