Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(REST): Added new Rest API endpoint for reading clearing request #1159

Merged
merged 1 commit into from
Apr 8, 2021
Merged

feat(REST): Added new Rest API endpoint for reading clearing request #1159

merged 1 commit into from
Apr 8, 2021

Conversation

akapti
Copy link
Contributor

@akapti akapti commented Mar 24, 2021

Please provide a summary of your changes here.

Created the REST endpoint to get the clearing request details based on

  1. Clearing request Id
  2. Project id

Issue: #1156

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?

  • User should be able to see the clearing request details by performing Get operation at endpoint:
  1. /api/clearingrequest/{CrId} where Clearing Request id is the URL param.
  2. /api/clearingrequest/project/{ProjectId} where Project Id is the URL param.

Have you implemented any additional tests?
No.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

Signed-off-by: Abdul Kapti abdul.kapti@siemens-healthineers.com

@akapti akapti added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Mar 24, 2021
@akapti akapti added this to Preparing in Pull Request Board via automation Mar 24, 2021
@akapti akapti moved this from Preparing to Ready for review in Pull Request Board Mar 24, 2021
@akapti akapti force-pushed the feat/RestApiForClearingRequest-1156 branch from 028ee60 to 4b943b2 Compare March 31, 2021 12:39
@akapti akapti linked an issue Apr 7, 2021 that may be closed by this pull request
Rest endpoint for Clearing Request #1156
Closed
feat(REST): Added new Rest API endpoint for reading clearing request
d97146a 
Signed-off-by: Abdul Kapti <abdul.kapti@siemens-healthineers.com>
@akapti akapti force-pushed the feat/RestApiForClearingRequest-1156 branch from 4b943b2 to d97146a Compare April 8, 2021 10:27
@akapti akapti moved this from Ready for review to Ready for test in Pull Request Board Apr 8, 2021
@smrutis1
Copy link
Contributor

smrutis1 commented Apr 8, 2021

Tested it. Working fine.

smrutis1
smrutis1 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@smrutis1 smrutis1 merged commit 8b61068 into eclipse-sw360:master Apr 8, 2021
Pull Request Board automation moved this from Ready for test to Merged to master Apr 8, 2021
@deveaud-m deveaud-m mentioned this pull request Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smrutis1 smrutis1 smrutis1 approved these changes

Assignees
No one assigned
Labels
needs general test This is general testing, meaning that there is no org specific issue to check for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rest endpoint for Clearing Request
2 participants
@akapti @smrutis1