Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .travis.yml #56

Closed
wants to merge 1 commit into from
Closed

Add .travis.yml #56

wants to merge 1 commit into from

Conversation

krichter722
Copy link

@krichter722 krichter722 commented May 31, 2018

Travis CI allows to detect build errors.

The build currently fails which I could reproduce locally as well, see https://travis-ci.org/krichter722/texlipse/builds/386282908 for details.

Since Travis CI has already been activated, but only started working with this script and fails, it might be necessary to fix the build issues and rebasing this PR on them before being able to merge it.

@eclipse-texlipse-bot
Copy link

Can one of the admins verify this patch?

@turesheim
Copy link
Contributor

TeXlipse does not use Travis for building, but rather Eclipse infrastructure. See https://ci.eclipse.org/texlipse/. In order for a patch to be contributed you must first sign the ECA. See https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=5b102fac99818

@krichter722
Copy link
Author

krichter722 commented May 31, 2018

TeXlipse does not use Travis for building, but rather Eclipse infrastructure. See https://ci.eclipse.org/texlipse/.

Then the existing CI doesn't detect build issues or is configured to allow commits which don't build. Travis CI is tightly integrated with GitHub and allows to prevent such annoyances (master should always build) (I don't feel annoyed, but other users and devs might).

In order for a patch to be contributed you must first sign the ECA. See https://dev.eclipse.org/eclipse-webhook/services/status_details.php?id=5b102fac99818

Done.

You might need to restart Travis since it's hanging.

@turesheim
Copy link
Contributor

turesheim commented May 31, 2018

Then the existing CI doesn't detect build issues or is configured to allow commits which don't build. Travis CI is tightly integrated with GitHub and allows to prevent such annoyances (master should always build) (I don't feel annoyed, but other users and devs might).

Actually the build is just fine. We have https://ci.eclipse.org/texlipse/job/nightly/ that runs nightly even if there has been no changes to confirm that. However the TeXlipse Jenkins builds jobs are set up to pull a prebuilt binary containing the Jazzy spell checker before starting the build. That is the bit missing from the .travis.yml The code is as follows.

#!/bin/sh

cd "$WORKSPACE/org.eclipse.texlipse"
# Jazzy's license is LGPL and does not have a binary distribution, so we need
# to download it from somewhere. See https://github.com/reckart/jazzy for the
# source code.
curl -O https://resheim.net/texlipse/jazzy-core.jar

Eclipse has it's own spell checker and Jazzy is causing licensing issues so we are looking to replace it. See issue #39.

Thanks for signing up as a contributor!

@krichter722
Copy link
Author

Thanks for your feedback. If Jenkins does the jobs right, Travis shouldn't be necessary, however, it's probably a one-liner if #39 is clarified, so we can leave this PR open as long as that not closed, and then see again. The build issue will most likely disappear after #57 is clarified; even if the necessity to download the extra dependency is temporary, I'd leave a note in the build instructions.

@turesheim
Copy link
Contributor

I agree that it's unfortunate that we have to pull the binary in this way. It was meant to be temporary until we got #39 resolved. But I ran out of time and haven't had the chance to look at it again. We could mend this by adding code to the pom.xm for obtaining the binary though.

@krichter722
Copy link
Author

Another example for insufficient CI setup: a235c4a causes mvn install to fail due to

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.5.1:compile (default-compile) on project org.eclipse.texlipse: Compilation failure: Compilation failure: 
[ERROR] /mnt/data/sources/texlipse/org.eclipse.texlipse/source/org/eclipse/texlipse/spelling/TexlipseWordFinder.java:[16] 
[ERROR] 	import com.swabunga.spell.event.AbstractWordFinder;
[ERROR] 	       ^^^^^^^^^^^^
[ERROR] The import com.swabunga cannot be resolved
[ERROR] /mnt/data/sources/texlipse/org.eclipse.texlipse/source/org/eclipse/texlipse/spelling/TexlipseWordFinder.java:[17] 
[ERROR] 	import com.swabunga.spell.event.Word;
[ERROR] 	       ^^^^^^^^^^^^
[ERROR] The import com.swabunga cannot be resolved
[ERROR] /mnt/data/sources/texlipse/org.eclipse.texlipse/source/org/eclipse/texlipse/spelling/TexlipseWordFinder.java:[18] 
[ERROR] 	import com.swabunga.spell.event.WordNotFoundException;
[ERROR] 	       ^^^^^^^^^^^^
[ERROR] The import com.swabunga cannot be resolved
[ERROR] /mnt/data/sources/texlipse/org.eclipse.texlipse/source/org/eclipse/texlipse/spelling/TexlipseWordFinder.java:[27] 
[ERROR] 	public class TexlipseWordFinder extends AbstractWordFinder {
[ERROR] 	                                        ^^^^^^^^^^^^^^^^^^
...

which should have been detected by the CI before merging into master.

That being said I'm not eager to push or maintain the Travis configuration, however if the current CI doesn't even detect compilation failures/allows the to be merged into master, it might be easier to start over with Travis and profit from the GitHub integration.

@fredg02
Copy link

fredg02 commented Sep 28, 2020

That being said I'm not eager to push or maintain the Travis configuration, however if the current CI doesn't even detect compilation failures/allows the to be merged into master, it might be easier to start over with Travis and profit from the GitHub integration.

The CI waited for admin approval before testing this (#89 (comment)), but never received it and therefore never kicked off a build.

@montex
Copy link
Contributor

montex commented Oct 6, 2020

@krichter722 I think the build problem has been fixed by #95

@Mailaender
Copy link

Travis CI is a CI service free for FLOSS projects.

Signed-off-by: Karl-Philipp Richter <krichter@posteo.de>
@krichter722
Copy link
Author

krichter722 commented Feb 15, 2021

There's limited build time available for OSS projects for free. That being said, I'm not eager to duplicate a working CI, however, it seems to be a good fallback.

@krichter722 krichter722 deleted the travis branch October 22, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants