Preparation for Node 14 #49
Conversation
chore(devDeps): increase latest major version
ci(travis): add node 14, 16 switch to --ignore-engines see TypeFox/find-git-exec#22
see eclipse-theia/dugite-extra#49 we can yolo this one adjust documenation see #93 see #91 see #94
|
@duncdrum I'm in the process of updating |
|
@duncdrum Version |
| "concurrently": "^6.2.0", | ||
| "cross-env": "^7.0.3", | ||
| "fs-extra": "^10.0.0", | ||
| "mocha": "^9.0.3", | ||
| "node-ssh": "^12.0.0", |
There was a problem hiding this comment.
The testing failures are due to these dev dependencies. E.g. mocha@^9 needs Node 12. Please revert the dev dependencies to the previous versions (or at least versions compatible with Node 10).
There was a problem hiding this comment.
please see my comments in #46 I don't see how downgrading mocha could possibly solve the fact that the default git branch name is main on new machines, while the tests hardcode master. This means tests will fail when run locally. I'd rather fix these 4 failing tests by addressing the underlying issues, before pinning an outdated mocha version.
|
@duncdrum Are you still interested in contributing these changes? Please upgrade |
|
@msujew i m back from my vacation and will update |
|
Is #54 a duplicate? I'm seeing the EOL for Node 12 is in early Q2 2022 so are there any plans to get this issue fixed in Q1? |
|
Closed in favor of #54 |
Chores
This includes a number of dependency updates, and config changes to enable building under node 14.
The source of the max-version is TypeFox/find-git-exec#22 so to enable building and running tests on node 13+ i changed the install command on CI, and added additional node versions on there as wel. (These won't run with this PR though since only
masteris configured to run CI. See #50close #48
Tests
The test failures, see #46, are present irrespective of node version. From my local testing it appears that the code behaves identical between
masterand here.Further changes to tests are necessary. I need some input on how you want to deal with these.
Code changes:
compatibility updates for latest version of deps. Added null check, and changed deprecated
mocha.optsDocumentation:
some edits to the readme
close #47
see #43