-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support generating an empty extension #54
Comments
removed option "example", added dedicated empty template Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
@JonasHelming I could not identify what
and selected the |
The hello world option handles this case correctly, try the "widget" :-) |
I tried using |
You are right, I retested that. So you just discovered even another bug. in the "configuring" of index.ts, the "example" input parameter is not added to parameters. Therefore, in the current state, the parameter is completly ignored. If it would not be ignored, it would lead to the issue described above. So this fix addresses both issues basically by removing the example option altogether (which did not even work) and replacing this with a dedicated template. |
PR: #55 |
removed option "example", added dedicated empty template Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Closed thanks to #55 |
This would be useful to set up a new contribution, which is not covered by an existing template. The option to not create an example is actually already existing ("example:boolean"). However, the option is not correctly processed by most existing templates. As a consequence, if you set "example" to false, the templates will create the frontend module, but not the contribution, which leads to not compilable code. I suggest to remove the option "example" and provide a dedcaited empty template. I will push a PR.
The text was updated successfully, but these errors were encountered: