Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch configs for 1.39.0 and earlier versions #173

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Jul 19, 2023

Because of the move of electron-main from frontend to backendwe have to adjust the launch configurations as well.

Tests

mkdir my-extension-38 && cd my-extension-38
yo theia-extension -t 1.38.0
(Hello World extension type)
(hello-world extension name)
yarn build:electron
Use "Start Electron Backend" launch config

mkdir my-extension-39 && cd my-extension-39
yo theia-extension -t 1.39.0
(Hello World extension type)
(hello-world extension name)
yarn build:electron
Use "Start Electron Backend" launch config

mkdir my-extension-latest && cd my-extension-latest
yo theia-extension
(Hello World extension type)
(hello-world extension name)
yarn build:electron
Use "Start Electron Backend" launch config

Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfaltermeier jfaltermeier merged commit 53d5d83 into master Jul 24, 2023
4 checks passed
@vince-fugnitto
Copy link
Member

@jfaltermeier @JonasHelming did we want to publish a new version with the fix?

@jfaltermeier
Copy link
Contributor Author

I guess it would be nice to have a fixed version. I believe the default version is latest, and this did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants