AppImage does not show a launcher Icon anymore #361

* splash screen windows may exist already, so we have to update existing
windows as well

Contributed on behalf of STMicroelectronics

Jenkinsfile

@@ -261,7 +261,7 @@ spec:
                         container('jnlp') {
                             script {
                                 uploadInstaller('windows')
-                                copyInstallerAndUpdateLatestYml('windows', 'TheiaIDESetup', 'exe', 'latest.yml', '1.46.0,1.46.100,1.47.0,1.47.100,1.48.0,1.48.300')
+                                copyInstallerAndUpdateLatestYml('windows', 'TheiaIDESetup', 'exe', 'latest.yml', '1.46.0,1.46.100,1.47.0,1.47.100,1.48.0,1.48.300,1.49.100')
                             }
                         }
                     }

applications/browser/package.json

@@ -3,7 +3,7 @@
   "name": "theia-ide-browser-app",
   "description": "Eclipse Theia IDE browser product",
   "productName": "Theia IDE",
-  "version": "1.49.100",
+  "version": "1.49.101",
   "license": "MIT",
   "author": "Eclipse Theia <theia-dev@eclipse.org>",
   "homepage": "https://github.com/eclipse-theia/theia-blueprint#readme",
@@ -86,7 +86,7 @@
     "@theia/vsx-registry": "1.49.1",
     "@theia/workspace": "1.49.1",
     "fs-extra": "^9.0.1",
-    "theia-ide-product-ext": "1.49.100"
+    "theia-ide-product-ext": "1.49.101"
   },
   "devDependencies": {
     "@theia/cli": "1.49.1"

applications/electron/package.json

@@ -3,7 +3,7 @@
   "name": "theia-ide-electron-app",
   "description": "Eclipse Theia IDE product",
   "productName": "Theia IDE",
-  "version": "1.49.100",
+  "version": "1.49.101",
   "main": "scripts/theia-electron-main.js",
   "license": "MIT",
   "author": "Eclipse Theia <theia-dev@eclipse.org>",
@@ -96,9 +96,9 @@
     "@theia/vsx-registry": "1.49.1",
     "@theia/workspace": "1.49.1",
     "fs-extra": "^9.0.1",
-    "theia-ide-launcher-ext": "1.49.100",
-    "theia-ide-product-ext": "1.49.100",
-    "theia-ide-updater-ext": "1.49.100"
+    "theia-ide-launcher-ext": "1.49.101",
+    "theia-ide-product-ext": "1.49.101",
+    "theia-ide-updater-ext": "1.49.101"
   },
   "devDependencies": {
     "@theia/cli": "1.49.1",

lerna.json

@@ -1,6 +1,6 @@
 {
   "lerna": "4.0.0",
-  "version": "1.49.100",
+  "version": "1.49.101",
   "useWorkspaces": true,
   "npmClient": "yarn",
   "command": {

package.json

@@ -1,6 +1,6 @@
 {
   "private": true,
-  "version": "1.49.100",
+  "version": "1.49.101",
   "license": "MIT",
   "author": "Rob Moran <github@thegecko.org>",
   "homepage": "https://github.com/eclipse-theia/theia-blueprint#readme",

theia-extensions/launcher/package.json

@@ -1,6 +1,6 @@
 {
   "name": "theia-ide-launcher-ext",
-  "version": "1.49.100",
+  "version": "1.49.101",
   "keywords": [
     "theia-extension"
   ],

theia-extensions/product/package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "theia-ide-product-ext",
-  "version": "1.49.100",
+  "version": "1.49.101",
   "description": "Eclipse Theia IDE Product Branding",
   "dependencies": {
     "@theia/core": "1.49.1",

theia-extensions/product/src/electron-main/icon-contribution.ts

@@ -13,6 +13,7 @@ import * as path from 'path';
 import { ElectronMainApplication, ElectronMainApplicationContribution } from '@theia/core/lib/electron-main/electron-main-application';
 
 import { injectable } from '@theia/core/shared/inversify';
+import { BrowserWindow } from '@theia/core/electron-shared/electron';
 
 @injectable()
 export class IconContribution implements ElectronMainApplicationContribution {
@@ -24,7 +25,12 @@ export class IconContribution implements ElectronMainApplicationContribution {
                 // The window image is undefined. If the executable has an image set, this is used as a fallback.
                 // Since AppImage does not support this anymore via electron-builder, set an image for the linux platform.
                 windowOptions.icon = path.join(__dirname, '../../resources/icons/WindowIcon/512-512.png');
+                // also update any existing windows, e.g. the splashscreen
+                for (const window of BrowserWindow.getAllWindows()) {
+                    window.setIcon(path.join(__dirname, '../../resources/icons/WindowIcon/512-512.png'));
+                }
             }
+
         }
     }
 }

theia-extensions/updater/package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "theia-ide-updater-ext",
-  "version": "1.49.100",
+  "version": "1.49.101",
   "description": "Eclipse Theia IDE Updater",
   "dependencies": {
     "@theia/core": "1.49.1",