Skip to content

Commit

Permalink
fix: disable splash screen before building Theia Electron
Browse files Browse the repository at this point in the history
The splash screen interferes with the Electron tests, causing them to fail.
Therefore, we disable it in the package.json of the electron example app.

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
  • Loading branch information
xai authored and planger committed May 29, 2024
1 parent 00f0bae commit 2932fdc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ jobs:
repository: eclipse-theia/theia
path: ./theia

- name: Patch Theia to disable splash screen
shell: bash
working-directory: ./theia
run: |
sed -i '/"splashScreenOptions": {/,/}/c\ "splashScreenOptions": {}' examples/electron/package.json
- name: Build Theia
shell: bash
working-directory: ./theia
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ jobs:
with:
repository: eclipse-theia/theia
path: ./theia
- name: Patch Theia to disable splash screen
shell: bash
working-directory: ./theia
run: |
sed -i '/"splashScreenOptions": {/,/}/c\ "splashScreenOptions": {}' examples/electron/package.json
- name: Copy webpack config
shell: bash
run: |
Expand Down

0 comments on commit 2932fdc

Please sign in to comment.