Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on frontend application contrib #202

Merged

Conversation

planger
Copy link
Contributor

@planger planger commented Sep 21, 2021

Fixes #201

Contributed on behalf of STMicroelectronics

Signed-off-by: Philip Langer planger@eclipsesource.com

planger and others added 2 commits September 21, 2021 20:20
Fixes eclipse-theia#201

Contributed on behalf of STMicroelectronics

Signed-off-by: Philip Langer <planger@eclipsesource.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JonasHelming
Copy link
Contributor

@planger : Could you resolve the conflict please. Don't worry too much about the menu structure, we have a follow up: #211

@planger
Copy link
Contributor Author

planger commented Sep 28, 2021

@planger : Could you resolve the conflict please. Don't worry too much about the menu structure, we have a follow up: #211

Sure, I resolved the conflict. Thanks!

@JonasHelming JonasHelming merged commit 3732d7e into eclipse-theia:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation on frontend application contributions
3 participants