[commands] log warning if a command is already registered instead of …

…throwing

this happens e.g. with `java.edit.organizeImports`, where commands are registered to be used for menus, but JDT LS will register the same command.

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>

packages/core/src/common/command.ts

@@ -101,6 +101,10 @@ export class CommandRegistry implements CommandService {
      * Throw if a command is already registered for the given command identifier.
      */
     registerCommand(command: Command, handler?: CommandHandler): Disposable {
+        if (this._commands[command.id]) {
+            console.warn(`A command ${command.id} is already registered.`);
+            return Disposable.NULL;
+        }
         if (handler) {
             const toDispose = new DisposableCollection();
             toDispose.push(this.doRegisterCommand(command));
@@ -111,9 +115,6 @@ export class CommandRegistry implements CommandService {
     }
 
     protected doRegisterCommand(command: Command): Disposable {
-        if (this._commands[command.id]) {
-            throw Error(`A command ${command.id} is already registered.`);
-        }
         this._commands[command.id] = command;
         return {
             dispose: () => {