Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[languages] Allow languages to override command registration #1034

Closed
JanKoehnlein opened this issue Jan 8, 2018 · 1 comment
Closed

[languages] Allow languages to override command registration #1034

JanKoehnlein opened this issue Jan 8, 2018 · 1 comment
Assignees
@JanKoehnlein

Comments

@JanKoehnlein
Copy link
Contributor

Currently, we have a problem in the theia-full docker image theia-ide/theia-apps#13 because both, yangster and go, override the DefaultCommands in order to do side-effects when the language server registers a command to the client.

We should add a language-specific hook to interact with the external command registration.
@JanKoehnlein JanKoehnlein self-assigned this Jan 8, 2018
JanKoehnlein added a commit that referenced this issue Jan 8, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
8c648e0 
…commands
JanKoehnlein added a commit that referenced this issue Jan 8, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
5fd5525 
…commands

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
JanKoehnlein added a commit that referenced this issue Jan 8, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
b92f60d 
…commands

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
This was referenced Jan 8, 2018
Closed
Closed
JanKoehnlein added a commit that referenced this issue Jan 8, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
adbd979 
…commands

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
JanKoehnlein added a commit that referenced this issue Jan 9, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
6e0ad26 
…commands

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
JanKoehnlein added a commit that referenced this issue Jan 9, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
cd4f1c5 
…commands

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
JanKoehnlein added a commit that referenced this issue Jan 9, 2018
@JanKoehnlein
GH-1034 allow languages to hook into the registration of server-side …
8b59524 
…commands

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
JanKoehnlein added a commit to theia-ide/yangster that referenced this issue Jan 10, 2018
@JanKoehnlein
GH-53 use language-specific command-registration hook
ffb40df 
see eclipse-theia/theia#1034

Signed-off-by: Jan Koehnlein <jan.koehnlein@typefox.io>
@akosyakov
Copy link
Member

@JanKoehnlein to migrate to a new monaco-languageclient, we will need to have a single commands instance for all languages. Would it be possible to rewrite go and yangster that they contribute commands to global command registry instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanKoehnlein JanKoehnlein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanKoehnlein @akosyakov