Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Support property SourceControlInputBox#visible #11140

Closed
Tracked by #9863
planger opened this issue May 11, 2022 · 4 comments · Fixed by #11412
Closed
Tracked by #9863

[vscode] Support property SourceControlInputBox#visible #11140

planger opened this issue May 11, 2022 · 4 comments · Fixed by #11412
Assignees
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 11, 2022

Feature Description:

Support specifying whether an SourceControlInputBox is visible.

@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility scm issues related to the source control manager labels May 11, 2022
@planger
Copy link
Contributor Author

planger commented May 12, 2022

Related to #5458

@JonasHelming
Copy link
Contributor

we will have a look at this

@KevinK-9
Copy link
Contributor

The UI of the InputBox is provided by the extension, so the API only needs to save and transmit the variables, correct?
Is there an extension to test this with, to see how the visibility variable is used by such an extension or another way to test the implementation?

@msujew
Copy link
Member

msujew commented Jun 27, 2022

The UI of the InputBox is provided by the extension, so the API only needs to save and transmit the variables, correct?

@KevinK-9 Yes, that's correct. I believe that's the way it also works for the already existing parts of this API, such as the placeholder.

Is there an extension to test this with, to see how the visibility variable is used by such an extension or another way to test the implementation?

Contributors of such features usually provide a small example vscode extension to test the changes if it isn't already covered by the existing vscode-sample repo. See for a more elaborate example this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
5 participants