Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect onView activation event generation #13090

Closed
msujew opened this issue Nov 22, 2023 · 0 comments · Fixed by #13091
Closed

Incorrect onView activation event generation #13090

msujew opened this issue Nov 22, 2023 · 0 comments · Fixed by #13091
Labels
bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@msujew
Copy link
Member

msujew commented Nov 22, 2023

Bug Description:

Since #12167 we automatically determine the activation events depending on certain other entries in the contributes part of the package.json. This doesn't work correctly as the views part isn't correctly generated.

Steps to Reproduce:

  1. Download and install this extension.
  2. Open the view and see that it's empty because the extension hasn't been activated yet.
  3. Reload the app, run the Add Colors command and open the view again. It's now populated because the extension has been activated.

Additional Information

  • Operating System: Any
  • Theia Version: 1.43.1
@msujew msujew added bug bugs found in the application vscode issues related to VSCode compatibility labels Nov 22, 2023
@msujew msujew added the webviews issues related to webviews label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant