Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onView activation event generation #13091

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix onView activation event generation #13091

merged 2 commits into from
Dec 21, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Nov 22, 2023

What it does

Closes #13090

Fixes a minor issue in the activation event generation that assumed a different typing for contributes.views.

How to test

  1. Download and install this extension.
  2. Open the view and see that the webview loads as expected (the activation event has been correctly generated).

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility webviews issues related to webviews labels Nov 22, 2023
@msujew msujew requested a review from tsmaeder November 28, 2023 15:11
@tsmaeder
Copy link
Contributor

When I open the view "Calico Colors", the view is empty.

@tsmaeder
Copy link
Contributor

tsmaeder commented Dec 21, 2023 •
edited
Loading

FYI: if I invoke "Clear Colors", the view shows a "Add Color" button, so this seems to be an activation problem.

@tsmaeder
Copy link
Contributor

O.K. it seems to work when working around #13157

@msujew msujew merged commit 0055c8c into master Dec 21, 2023
14 checks passed
@msujew msujew deleted the msujew/fix-onview-activation-event branch December 21, 2023 15:50
@github-actions github-actions bot added this to the 1.45.0 milestone Dec 21, 2023
@msujew msujew mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder tsmaeder approved these changes

Assignees

@tsmaeder tsmaeder

Labels
vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
PR Backlog
Archived in project
Milestone
1.45.0
Development

Successfully merging this pull request may close these issues.

Incorrect onView activation event generation
2 participants
@msujew @tsmaeder