Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot checkout branches via UI #13450

Closed
Tracked by #13192
sgraband opened this issue Mar 4, 2024 · 1 comment · Fixed by #13451
Closed
Tracked by #13192

Cannot checkout branches via UI #13450

sgraband opened this issue Mar 4, 2024 · 1 comment · Fixed by #13451
Assignees
Milestone

Comments

@sgraband
Copy link
Contributor

sgraband commented Mar 4, 2024

Bug Description:

With the current Theia IDE preview (1.47.0) i can no longer checkout branches via the UI. When clicking on the current branch in the bootom left the correct branches are shown to select (to checkout), but clicking on any branch does not do anything. Same applies when executing the command (Checkout to...) manually.

Note: There seems to be a random empty entry in the overview of branches to checkout.

Steps to Reproduce:

  1. Click on the current branch in the bottom left (or run the Checkout to... command)
  2. Click on any branch in the selection menu
  3. Notice that the branch does not change in the UI
  4. Double check in a terminal that the branch was not changed.

Additional Information

  • Operating System: Ubuntu 22.04
  • Theia Version: Theia IDE 1.47.0 (preview)
@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 4, 2024

Debugging through the git extension reveals that QuickPick.activeItems is empty when `QuickPick.onDidAccept()' fires. That means the checkout command never has anything to check out.

@tsmaeder tsmaeder self-assigned this Mar 4, 2024
tsmaeder added a commit to tsmaeder/theia that referenced this issue Mar 4, 2024
Fixes eclipse-theia#13450, eclipse-theia#13449

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder added a commit that referenced this issue Mar 5, 2024
Fixes #13450, #13449

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
jfaltermeier pushed a commit that referenced this issue Mar 6, 2024
Fixes #13450, #13449

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
jonah-iden pushed a commit that referenced this issue Mar 15, 2024
Fixes #13450, #13449

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
jonah-iden added a commit that referenced this issue Mar 22, 2024
* basics for dev-container support

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* basic creating and connecting to container working

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* open workspace when opening container

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* save and reuse last USed container per workspace

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* restart container if running

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* better container creation extension features

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* added dockerfile support

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* rebuild container if devcontainer.json has been changed since last use

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fix build

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fixed checking if container needs rebuild

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* working port forwarding via exec instance

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* review changes

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fix import

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* smaller fixes and added support for multiple devcontainer configuration files

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* basic output window for devcontainer build

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* smaller review changes and nicer dockerfile.json detection code

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fixed build and docuemented implemented devcontainer.json properties

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* Fix unneeded URI conversion (#13415)

* Fix quickpick problems found in IDE testing (#13451)

Fixes #13450, #13449

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>

* Fix rending of quickpick buttons (#13342)

Ensure that  the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

Fixes #13076

Contributed on behalf of STMicroelectronics

* electron: allow accessing the metrics endpoint for performance analysis (#13380)

By default, when running Theia in Electron, all endpoints are protected
by the ElectronTokenValidator.
This patch allows accessing the '/metrics' endpoint without a token,
which enables us to collect metrics for performance analysis.

For this, ElectronTokenValidator is extended to allow access to the
metrics endpoint. All other endpoints are still protected.

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>

* fixed renaming and moving of open notebooks (#13467)

* fixed renameing of open notebooks

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fixed moving of notebook editors to other areas

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

---------

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* [playwright] Update documentation

Since a recent enhancement/refactoring of @theia/playwright, to permit using it in Theia
Electron applications, the way to load an application has changed. This commit is an
attempt to update the examples that are part of the documentation. I validated the changes
in the "theia-playwright-template" repository, and so I have adapted the sample code to
that repo's linting rules (using single quotes instead of double).

It's possible that other things have changed, that I have not yet encountered, but this
should be a good step forward, at least for those just getting started integrating
playwright to test their Theia-based app.

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>

* basics for dev-container support

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* basic creating and connecting to container working

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* added dockerfile support

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* added port forwarding inlcuding ui

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* basic port/address validation

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fixed allready forwarded port checking

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* rebase  fixes

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* removed unused file

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* review changes

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* fixed widget focus and message margin

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

* default port binding now shows as 0.0.0.0

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>

---------

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Co-authored-by: Alexander Taran <Alexander-Taran@users.noreply.github.com>
Co-authored-by: Thomas Mäder <tsmaeder@users.noreply.github.com>
Co-authored-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
Co-authored-by: Olaf Lessenich <olessenich@eclipsesource.com>
Co-authored-by: Marc Dumais <marc.dumais@ericsson.com>
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants