Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fs-watcher][git] Filter the .git/index.lock from the file changes #1769

Closed
kittaakos opened this issue Apr 24, 2018 · 2 comments
Closed

[fs-watcher][git] Filter the .git/index.lock from the file changes #1769

kittaakos opened this issue Apr 24, 2018 · 2 comments
Labels
git issues related to git quality issues related to code and application quality

Comments

@kittaakos
Copy link
Contributor

Currently, each tracked Git repository is checked (via the git status command) whether there were any changes or not. This happens periodically (5 seconds) on the backend.

  • First question, why does the git status create a new index.lock file. AFAIK, it should happen only when the performed Git command edits the index. git status should not. See git --no-optional-locks status
  • Can we avoid tracking the .git/index.lock file changes?

Currently, it does not cause any issues/side-effects.
@kittaakos kittaakos added quality issues related to code and application quality git issues related to git labels Apr 24, 2018
@kittaakos kittaakos mentioned this issue Jun 21, 2018
Closed
@kittaakos
Copy link
Contributor Author

atom/github#961 (comment)

@kittaakos
Copy link
Contributor Author

Git 2.15 is a must for this feature. The followings are required to support it:

  • Update the dugite dependency inside dugite-extra. The current (bundled) Git version is just 2.14.1. We either update to the latest dugite (that is the harder way because there were API changes) or we just bump up to 1.49.0. The current dugite version is 1.42.0.
  • Make sure all the Docker images have at least Docker Git 2.15.
  • Theia (maybe dugite-extra) should be smart enough to check the Git version and do not call --no-optional-locks if that is not supported.

CC: @svenefftinge

@kittaakos kittaakos mentioned this issue Aug 1, 2018
Closed
kittaakos pushed a commit that referenced this issue Aug 1, 2018
GH-1769: Enabled --no-optional-locks for Git.
7eb6fdf 
So that a `git status` call will not end up in a index.lock file change.

The `--no-optional-locks` is enabled by default for > 2.15.0 Git.
Earlier Git versions are uneffected.

Closes #1769.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Aug 1, 2018
Merged
kittaakos pushed a commit that referenced this issue Aug 1, 2018
GH-1769: Enabled --no-optional-locks for Git.
843f4ce 
So that a `git status` call will not end up in a index.lock file change.

The `--no-optional-locks` is enabled by default for > 2.15.0 Git.
Earlier Git versions are uneffected.

Closes #1769.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
kittaakos pushed a commit that referenced this issue Aug 1, 2018
@kittaakos
GH-1769: Enabled --no-optional-locks for Git.
3ef537c 
So that a `git status` call will not end up in a index.lock file change.

The `--no-optional-locks` is enabled by default for > 2.15.0 Git.
Earlier Git versions are uneffected.

Closes #1769.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
marcdumais-work pushed a commit to marcdumais-work/theia that referenced this issue Oct 15, 2018
@marcdumais-work
eclipse-theiaGH-1769: Enabled --no-optional-locks for Git.
6602b56 
So that a `git status` call will not end up in a index.lock file change.

The `--no-optional-locks` is enabled by default for > 2.15.0 Git.
Earlier Git versions are uneffected.

Closes eclipse-theia#1769.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git issues related to git quality issues related to code and application quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kittaakos