Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a command to theia cli to trim unnecessary files #3320

Open
akosyakov opened this issue Oct 30, 2018 · 3 comments
Open

add a command to theia cli to trim unnecessary files #3320

akosyakov opened this issue Oct 30, 2018 · 3 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help theia-cli issues related to the theia-cli

Comments

@akosyakov
Copy link
Member

See discussions here: theia-ide/theia-apps#94 (comment)

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves theia-cli issues related to the theia-cli labels Oct 30, 2018
@uniibu
Copy link
Contributor

uniibu commented Oct 30, 2018

I don't know much about using lerna in particular, but correct me if im wrong, i think adding this to lerna.json

...
"commands": {
    "publish": {
      "ignore": [
        "*.md",
        "*.ts",
       "*.ts.map",
        "*.txt",
        "test/**"
        ... etc
      ]
    }
}
...

would prevent lerna from publishing those unnecessary files.

Or ofcourse if .npmignore works normally with lerna then those unnecessary files could be listed there.

@akosyakov
Copy link
Member Author

We want to publish them for extension developers that they can have a look at source code and example usages. Only developers building prod applications should use this command.

@uniibu
Copy link
Contributor

uniibu commented Oct 31, 2018

To further discuss, i think adding a command to cli might not work. Because doing yarn --production will remove cli as devdependency, and if you do it before doing yarn --production, it will add back those files.

I think adding option on build would be nice, something like yarn theia build --production which would remove unnecessary files and devdependencies.

@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help theia-cli issues related to the theia-cli
Projects
None yet
Development

No branches or pull requests

2 participants