Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plug-in] Implement 'vscode.diff' VS Code Built-in Command #4052

Closed
vparfonov opened this issue Jan 14, 2019 · 2 comments
Closed

[plug-in] Implement 'vscode.diff' VS Code Built-in Command #4052

vparfonov opened this issue Jan 14, 2019 · 2 comments
Assignees
@vzhukovs
Labels
plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team

Comments

@vparfonov
Copy link
Contributor

Details hare: https://code.visualstudio.com/api/references/commands

vscode.diff - Opens the provided resources in the diff editor to compare their contents.

left - Left-hand side resource of the diff editor
right - Right-hand side resource of the diff editor
title - (optional) Human readable title for the diff editor
options - (optional) Editor options, see vscode.TextDocumentShowOptions
@vparfonov vparfonov added plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team labels Jan 14, 2019
This was referenced Jan 14, 2019
Open
Closed
@vparfonov vparfonov mentioned this issue Feb 4, 2019
Closed
13 tasks
@vzhukovs vzhukovs self-assigned this Feb 21, 2019
@vzhukovs
Copy link
Contributor

Merged: #4315

@akosyakov
Copy link
Member

@vparfonov @vzhukovskii Can be closed?

benoitf added a commit that referenced this issue Apr 24, 2019
@benoitf
Fix #4052 implementation of vscode.diff command
d67e6f9 
diff-service should only check URI on filesystem if it's file URI as it doesn't work for example if URIs are coming from workspace.registerTextDocumentContentProvider

Also fix propagation of DisplayName of the diff URI when used as 3rd argument of vscode.diff command

Change-Id: I7e034f72e8b8f8582104be12d545bbae5d8f7921
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Apr 24, 2019
@benoitf
Fix #4052 implementation of vscode.diff command
ad0b31e 
diff-service should only check URI on filesystem if it's file URI as it doesn't work for example if URIs are coming from workspace.registerTextDocumentContentProvider

Also fix propagation of DisplayName of the diff URI when used as 3rd argument of vscode.diff command

Change-Id: I7e034f72e8b8f8582104be12d545bbae5d8f7921
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Apr 24, 2019
@benoitf
Fix #4052 implementation of vscode.diff command
1160fc4 
diff-service should only check URI on filesystem if it's file URI as it doesn't work for example if URIs are coming from workspace.registerTextDocumentContentProvider

Also fix propagation of DisplayName of the diff URI when used as 3rd argument of vscode.diff command

Change-Id: I7e034f72e8b8f8582104be12d545bbae5d8f7921
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Apr 24, 2019
@benoitf
Fix #4052 implementation of vscode.diff command
8a8b89e 
diff-service should only check URI on filesystem if it's file URI as it doesn't work for example if URIs are coming from workspace.registerTextDocumentContentProvider

Also fix propagation of DisplayName of the diff URI when used as 3rd argument of vscode.diff command

Change-Id: I7e034f72e8b8f8582104be12d545bbae5d8f7921
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Apr 25, 2019
@benoitf
Fix #4052 implementation of vscode.diff command
dcf570d 
diff-service should only check URI on filesystem if it's file URI as it doesn't work for example if URIs are coming from workspace.registerTextDocumentContentProvider

Also fix propagation of DisplayName of the diff URI when used as 3rd argument of vscode.diff command

Change-Id: I7e034f72e8b8f8582104be12d545bbae5d8f7921
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
DoroNahari pushed a commit to DoroNahari/theia that referenced this issue Apr 29, 2019
@benoitf
Fix eclipse-theia#4052 implementation of vscode.diff command
2af5174 
diff-service should only check URI on filesystem if it's file URI as it doesn't work for example if URIs are coming from workspace.registerTextDocumentContentProvider

Also fix propagation of DisplayName of the diff URI when used as 3rd argument of vscode.diff command

Change-Id: I7e034f72e8b8f8582104be12d545bbae5d8f7921
Signed-off-by: Florent Benoit <fbenoit@redhat.com>

Signed-off-by: Doron Nahari doron.nahari@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhukovs vzhukovs

Labels
plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vparfonov @vzhukovs @akosyakov