Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin-Api] Apply window.registerUriHandler() function #5119

Open
vinokurig opened this issue May 11, 2019 · 5 comments
Open

[Plugin-Api] Apply window.registerUriHandler() function #5119

vinokurig opened this issue May 11, 2019 · 5 comments
Labels
plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team vscode issues related to VSCode compatibility

Comments

@vinokurig
Copy link
Contributor

Description

Apply window.registerUriHandler()VsCode Plugin Api function.
Related VsCode function: https://github.com/microsoft/vscode/blob/73acf433f71855f5c9f24b7e383a55c856613257/src/vs/vscode.d.ts#L6668-L6689

@vinokurig vinokurig added plug-in system issues related to the plug-in system todo larger scoped issues labels May 11, 2019
@akosyakov akosyakov added vscode issues related to VSCode compatibility and removed todo larger scoped issues labels Jul 5, 2019
@akosyakov
Copy link
Member

Does anyone know an example of VS Code extension making use of it?

@akosyakov
Copy link
Member

akosyakov commented Jul 5, 2019

@benoitf
Copy link
Contributor

benoitf commented Jul 5, 2019

I think it's useful for electron mode, but I don't know how to handle it correctly on browser mode.

@akosyakov
Copy link
Member

I think it's useful for electron mode

Can you elaborate? I still cannot get my head around where it is used.

My plan is to add Developer: Open URL command, similarly to VS Code. But i wonder whether it is used somewhere else?

@benoitf
Copy link
Contributor

benoitf commented Jul 5, 2019

@akosyakov I was thinking that URI Handler are for the system

so let say I register foo: URI handler, if I enter in my browser foo://bar then it can be handled
but in Theia used in browser mode, system handler is managed on the server side so even if I enter in my browser foo:// it won't be intercepted.
IMHO It's really working only when remotee and client are on the same machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants