[Plugin-Api] Add stub implementation of window.registerUriHandler() #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azatsarynnyy
approved these changes
May 11, 2019
15 tasks
|
hello, stub implementation should be avoided as much as possible now, when are you planning full implementation referenced by #5119 ? |
|
@benoitf Since Extend VsCode pull-request plugin (eclipse-che/che#10282) has the highest priority, we plan to start work on full implementation after eclipse-che/che#10282. This PR is needed to launch the VsCode pull-request plugin. |
benoitf
approved these changes
May 20, 2019
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stub implementation of the VsCode
window.registerUriHandler()Api function.Full implementation is going to be done in #5119
Is needed for eclipse-che/che#11867